Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: set normalizeTD text default to empty string #51543

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Jan 22, 2024

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 22, 2024
@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 22, 2024
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 23, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 24, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51543
✔  Done loading data for nodejs/node/pull/51543
----------------------------------- PR info ------------------------------------
Title      tools: set normalizeTD text default to empty string (#51543)
Author     Marco Ippolito  (@marco-ippolito)
Branch     marco-ippolito:fix/update-root-certs -> nodejs:main
Labels     tools, author ready
Commits    1
 - tools: set normalizeTD text default to empty string
Committers 1
 - marco-ippolito 
PR-URL: https://github.com/nodejs/node/pull/51543
Fixes: https://github.com/nodejs/node/actions/runs/7597757959/job/20692964963
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51543
Fixes: https://github.com/nodejs/node/actions/runs/7597757959/job/20692964963
Reviewed-By: Richard Lau 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 22 Jan 2024 17:26:56 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/51543#pullrequestreview-1837150227
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51543#pullrequestreview-1837297960
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51543#pullrequestreview-1837700370
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51543
From https://github.com/nodejs/node
 * branch                  refs/pull/51543/merge -> FETCH_HEAD
✔  Fetched commits as 925a464cb8ba..f1867bca157f
--------------------------------------------------------------------------------
[main b19e19e8b3] tools: set normalizeTD text default to empty string
 Author: marco-ippolito 
 Date: Mon Jan 22 18:25:23 2024 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
tools: set normalizeTD text default to empty string

PR-URL: #51543
Fixes: https://github.com/nodejs/node/actions/runs/7597757959/job/20692964963
Reviewed-By: Richard Lau rlau@redhat.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

[main 6c4fda3f52] tools: set normalizeTD text default to empty string
Author: marco-ippolito marcoippolito54@gmail.com
Date: Mon Jan 22 18:25:23 2024 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
✖ 6c4fda3f52c72c9acbd2a7762f15374db7259c7f
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✖ 2:7 Fixes must be a GitHub URL. fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
git commit --amend
Once commit message is fixed, finish the landing command running
git node land --continue

https://github.com/nodejs/node/actions/runs/7643958471

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 24, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2024
@nodejs-github-bot nodejs-github-bot merged commit d8e385a into nodejs:main Jan 24, 2024
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d8e385a

@richardlau
Copy link
Member

marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Feb 2, 2024
PR-URL: nodejs#51543
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
PR-URL: nodejs#51543
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51543
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito added a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
PR-URL: nodejs#51543
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51543
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51543
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants