Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: fix NO_COLORS env var is ignored #51568

Merged
merged 1 commit into from
Jan 31, 2024
Merged

repl: fix NO_COLORS env var is ignored #51568

merged 1 commit into from
Jan 31, 2024

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jan 26, 2024

refs: #48034 (comment)

the logic in options.useColors = shouldColorize(options.output) || process.env.NODE_DISABLE_COLORS === undefined; indroduced this bug since shouldColorize already checks NODE_DISABLE_COLORS among other env vars that disable colors: NO_COLOR and TERM === 'dumb'

@MoLow MoLow requested a review from addaleax January 26, 2024 08:39
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Jan 26, 2024
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56928/

addaleax
addaleax approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@anonrig
Copy link
Member

anonrig commented Jan 27, 2024

Can we add a test, so we don't regress?

@MoLow
Copy link
Member Author

MoLow commented Jan 27, 2024

Can we add a test, so we don't regress?

there were already existing tests that needed fixing

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56935/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56945/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56971/

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 31, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2024
@nodejs-github-bot nodejs-github-bot merged commit a501315 into nodejs:main Jan 31, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a501315

@MoLow MoLow deleted the fix-no-colors branch January 31, 2024 08:35
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Jan 31, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
@MoLow @rdw-msft
repl: fix NO_COLORS env var is ignored
ddd157b 
PR-URL: nodejs#51568
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@MoLow @targos
repl: fix NO_COLORS env var is ignored
3e579ab 
PR-URL: #51568
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@MoLow @marco-ippolito
repl: fix NO_COLORS env var is ignored
09df9d2 
PR-URL: nodejs#51568
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@MoLow @richardlau
repl: fix NO_COLORS env var is ignored
50ec690 
PR-URL: #51568
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@MoLow @richardlau
repl: fix NO_COLORS env var is ignored
f94336f 
PR-URL: #51568
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MoLow @nodejs-github-bot @anonrig @addaleax @benjamingr @lpinca @BridgeAR