Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: move one or more collaborators to emeritus #51588

Closed
wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/find-inactive-collaborators.yml.

@nodejs/tsc Please follow up with the offboarding tasks.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Jan 29, 2024
@mcollina
Copy link
Member

This sound strange.

@targos
Copy link
Member

targos commented Jan 29, 2024

This usually happens when the email address is not the same as in the commit log

@mcollina
Copy link
Member

cc @lemire

@anonrig anonrig added the blocked PRs that are blocked by other issues or PRs. label Jan 29, 2024
@lemire
Copy link
Member

lemire commented Jan 29, 2024

I am too new to be emeritus!!!

@lemire
Copy link
Member

lemire commented Jan 29, 2024

I'll see about issuing a new PR.

@aduh95
Copy link
Contributor

aduh95 commented Jan 29, 2024

@lemire the issue is that the bot cannot find any commit attributed to the email address associated with you in the README. The issue is that af3e2b2 is attributed to daniel@lemire.me and not lemire@gmail.com. You can validate that using the following command:

git show --format=%aE af3e2b24938598171a3f9a0000da58bd2968e812

You need to add another .mailmap entry so that git knows both email addresses linked to you – and/or you can update the README to use the email address @lemire.me.

@lemire
Copy link
Member

lemire commented Jan 29, 2024

add another .mailmap entry

Sounds less invasive. Let me research this option.

@lemire
Copy link
Member

lemire commented Jan 29, 2024

I have created PR that should fix the issue, see #51600

@aduh95 aduh95 deleted the actions/inactive-collaborators branch January 29, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants