Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document the GN build #51676

Merged
merged 2 commits into from
Feb 12, 2024
Merged

doc: document the GN build #51676

merged 2 commits into from
Feb 12, 2024

Conversation

zcbenz
Copy link
Contributor

@zcbenz zcbenz commented Feb 6, 2024

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 6, 2024
doc/contributing/gn-build.md Outdated Show resolved Hide resolved
doc/contributing/gn-build.md Show resolved Hide resolved
doc/contributing/gn-build.md Outdated Show resolved Hide resolved
doc/contributing/gn-build.md Outdated Show resolved Hide resolved
doc/contributing/gn-build.md Outdated Show resolved Hide resolved
doc/contributing/gn-build.md Outdated Show resolved Hide resolved
doc/contributing/gn-build.md Show resolved Hide resolved
doc/contributing/gn-build.md Outdated Show resolved Hide resolved
doc/contributing/gn-build.md Outdated Show resolved Hide resolved
doc/contributing/gn-build.md Outdated Show resolved Hide resolved
@debadree25 debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2024
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/51676
✔  Done loading data for nodejs/node/pull/51676
----------------------------------- PR info ------------------------------------
Title      doc: document the GN build (#51676)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     zcbenz:patch-16 -> nodejs:main
Labels     doc, author ready
Commits    2
 - doc: document the GN build
 - solve review comments
Committers 1
 - Cheng Zhao 
PR-URL: https://github.com/nodejs/node/pull/51676
Reviewed-By: Marco Ippolito 
Reviewed-By: Joyee Cheung 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/51676
Reviewed-By: Marco Ippolito 
Reviewed-By: Joyee Cheung 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 06 Feb 2024 07:38:09 GMT
   ✔  Approvals: 4
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51676#pullrequestreview-1865129648
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51676#pullrequestreview-1868163517
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/51676#pullrequestreview-1870860955
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51676#pullrequestreview-1871583729
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 51676
From https://github.com/nodejs/node
 * branch                  refs/pull/51676/merge -> FETCH_HEAD
✔  Fetched commits as 8a41d9b636be..9cc929bfe67c
--------------------------------------------------------------------------------
[main 4c1504f6d6] doc: document the GN build
 Author: Cheng Zhao 
 Date: Tue Feb 6 16:36:53 2024 +0900
 1 file changed, 112 insertions(+)
 create mode 100644 doc/contributing/gn-build.md
[main 160d3b3d4b] solve review comments
 Author: Cheng Zhao 
 Date: Wed Feb 7 14:54:44 2024 +0900
 1 file changed, 30 insertions(+), 17 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: document the GN build

PR-URL: #51676
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Debadree Chatterjee debadree333@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

[detached HEAD b332db3649] doc: document the GN build
Author: Cheng Zhao zcbenz@gmail.com
Date: Tue Feb 6 16:36:53 2024 +0900
1 file changed, 112 insertions(+)
create mode 100644 doc/contributing/gn-build.md
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
solve review comments

PR-URL: #51676
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Debadree Chatterjee debadree333@gmail.com
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io

[detached HEAD 38285d1023] solve review comments
Author: Cheng Zhao zcbenz@gmail.com
Date: Wed Feb 7 14:54:44 2024 +0900
1 file changed, 30 insertions(+), 17 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/7839027752

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Feb 9, 2024
@debadree25 debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Feb 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit 544cfc5 into nodejs:main Feb 12, 2024
27 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 544cfc5

targos pushed a commit that referenced this pull request Feb 15, 2024
PR-URL: #51676
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 20, 2024
PR-URL: nodejs#51676
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51676
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
PR-URL: #51676
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants