Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove test-fs-stat-bigint flaky designation #51735

Merged
merged 1 commit into from
Feb 22, 2024
Merged

test: remove test-fs-stat-bigint flaky designation #51735

merged 1 commit into from
Feb 22, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Feb 12, 2024

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 12, 2024
mertcanaltin
mertcanaltin approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 15, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57094/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57105/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/57131/

mhdawson
mhdawson approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit c1fa929 into nodejs:main Feb 22, 2024
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c1fa929

@lpinca lpinca deleted the remove/flaky-test-fs-stat-bigint branch February 22, 2024 18:33
marco-ippolito pushed a commit that referenced this pull request Feb 26, 2024
@lpinca @marco-ippolito
test: remove test-fs-stat-bigint flaky designation
11a493d 
Refs: #31727 (comment)
PR-URL: #51735
Reviewed-By: Michael Dawson <midawson@redhat.com>
marco-ippolito pushed a commit that referenced this pull request Feb 27, 2024
@lpinca @marco-ippolito
test: remove test-fs-stat-bigint flaky designation
2fb620c 
Refs: #31727 (comment)
PR-URL: #51735
Reviewed-By: Michael Dawson <midawson@redhat.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@lpinca @richardlau
test: remove test-fs-stat-bigint flaky designation
b425054 
Refs: #31727 (comment)
PR-URL: #51735
Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@lpinca @richardlau
test: remove test-fs-stat-bigint flaky designation
853b48d 
Refs: #31727 (comment)
PR-URL: #51735
Reviewed-By: Michael Dawson <midawson@redhat.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@lpinca @rdw-msft
test: remove test-fs-stat-bigint flaky designation
61dd4f1 
Refs: nodejs#31727 (comment)
PR-URL: nodejs#51735
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lpinca @nodejs-github-bot @mhdawson @mertcanaltin