tools: disable automated libuv updates #51775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
RafaelGSS
force-pushed
the
disable-libuv-update
branch
from
6359c62 to
9f8e928
Compare
mhdawson
reviewed
Feb 15, 2024
| @@ -174,14 +173,6 @@ jobs: | |||
| cat temp-output | |||
| tail -n1 temp-output | grep "NEW_VERSION=" >> "$GITHUB_ENV" || true | |||
| rm temp-output | |||
| - id: libuv | |||
There was a problem hiding this comment.
Can we just comment this out instead of removing, I assume we will want to add it back at some point?
There was a problem hiding this comment.
The other question is if we could have the update apply a patch required to re-apply the changes?
There was a problem hiding this comment.
I don't know, technically we could, but we'll need to review it carefully all libuv automatic updates + resolve conflicts.
RafaelGSS
force-pushed
the
disable-libuv-update
branch
from
9f8e928 to
a2fba64
Compare
edsadr
reviewed
Feb 19, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes.
RafaelGSS
force-pushed
the
disable-libuv-update
branch
from
a2fba64 to
847748d
Compare
|
ping @nodejs/actions @nodejs/security-wg |
joyeecheung
approved these changes
Feb 23, 2024
marco-ippolito
approved these changes
Feb 23, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a492646 |
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 26, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Feb 27, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: #51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes. PR-URL: nodejs#51775 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the previous security release modified the bundled version of libuv, we cannot automatically update libuv without potentially undoing those changes.
cc: @nodejs/security-wg