test: fix child-process-fork-regr-gh-2847 again #5179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
force-pushed
the
fix_test_again
branch
from
d41d9f4
to
b654355
Compare
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442.
santigimeno
force-pushed
the
fix_test_again
branch
from
b654355
to
3cf2461
Compare
mscdex
added
child_process
|
CI looks good (two unrelated test failures that I'll look into). |
|
LGTM |
|
CI is broken until this lands and it's a small restore to test-only code that affects Windows only and that was there until very recently, so I'm going to make the judgment call that this can land sooner than usual. Posting this here to give anyone paying close attention a chance to say "no! disagree! stop!" in the next several minutes... |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Feb 10, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs#5179 Reviewed-By: Rich Trott <rtrott@gmail.com> Fixes: nodejs#3635
|
Landed in 24667ee |
rvagg
pushed a commit
that referenced
this pull request
Feb 15, 2016
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Merged
stefanmb
pushed a commit
to stefanmb/node
that referenced
this pull request
Feb 23, 2016
Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR nodejs#4442. PR-URL: nodejs#5179 Reviewed-By: Rich Trott <rtrott@gmail.com> Fixes: nodejs#3635
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
3 tasks
refack
added a commit
to refack/node
that referenced
this pull request
May 19, 2017
According to the explanation in nodejs#3635#issuecomment-157714683 And as a continuation to nodejs#5422 we also ignore EMFILE "No more file descriptors are available,so no more files can be opened" PR-URL: nodejs#12698 Fixes: nodejs#10286 Refs: nodejs#3635 (comment) Refs: nodejs#5178 Refs: nodejs#5179 Refs: nodejs#4005 Refs: nodejs#5121 Refs: nodejs#5422 Refs: nodejs#12621 (comment) Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 17, 2017
According to the explanation in #3635#issuecomment-157714683 And as a continuation to #5422 we also ignore EMFILE "No more file descriptors are available,so no more files can be opened" PR-URL: #12698 Fixes: #10286 Refs: #3635 (comment) Refs: #5178 Refs: #5179 Refs: #4005 Refs: #5121 Refs: #5422 Refs: #12621 (comment) Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows is still sometimes failing with ECONNRESET. Bring back the
handling of this error as was initially introduced in PR #4442.