Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update guide link for Event Loop #51874

Merged
merged 1 commit into from
Feb 27, 2024
Merged

doc: update guide link for Event Loop #51874

merged 1 commit into from
Feb 27, 2024

Conversation

shrujalshah28
Copy link
Contributor

Fixes #51872

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Feb 25, 2024
@MoLow MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLow
Copy link
Member

MoLow commented Feb 26, 2024

@ovflowd do we have a way to fix this broken link prior to the next version release?

@ovflowd
Copy link
Member

ovflowd commented Feb 26, 2024

Yea the issue is that the redirect is not working correctly.

Ill make a hotfix in a few on nodejs.org side of things, we shouldn't need to change the link here.

ovflowd
ovflowd approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is being deployed on Node.js Website. Note that this can still be merged for the sake of being up-to-date; But isn't needed anymore.

@ovflowd ovflowd requested a review from trivikr February 26, 2024 10:10
@ovflowd
Copy link
Member

ovflowd commented Feb 26, 2024

(Upsie, accidentally clicked on the button of request re-review)

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7824a79 into nodejs:main Feb 27, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7824a79

marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@shrujalshah28 @marco-ippolito
doc: update guide link for Event Loop
49a3c38 
PR-URL: #51874
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Feb 29, 2024
@shrujalshah28 @marco-ippolito
doc: update guide link for Event Loop
db30428 
PR-URL: #51874
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@shrujalshah28 @richardlau
doc: update guide link for Event Loop
537afed 
PR-URL: #51874
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@shrujalshah28 @richardlau
doc: update guide link for Event Loop
b7ce547 
PR-URL: #51874
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@shrujalshah28 @rdw-msft
doc: update guide link for Event Loop
2ffe097 
PR-URL: nodejs#51874
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@ovflowd ovflowd ovflowd approved these changes

@MoLow MoLow MoLow approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@lpinca lpinca lpinca approved these changes

@bnb bnb bnb approved these changes

@trivikr trivikr Awaiting requested review from trivikr

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

404 hyperlink in nextTick documentation
10 participants
@shrujalshah28 @MoLow @ovflowd @nodejs-github-bot @bnb @lpinca @UlisesGascon @Ayase-252 @trivikr @marco-ippolito