Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix actual result of example is different in events #51925

Merged
merged 1 commit into from
Mar 2, 2024
Merged

doc: fix actual result of example is different in events #51925

merged 1 commit into from
Mar 2, 2024

Conversation

deokjinkim
Copy link
Contributor

@deokjinkim deokjinkim commented Feb 29, 2024 •
edited
Loading

Expected result:

a b MyEmitter {
  _events: [Object: null prototype] { event: [Function (anonymous)] },
  _eventsCount: 1,
  _maxListeners: undefined,
  [Symbol(kCapture)]: false
} true

Actual result:

a b MyEmitter {
  _events: [Object: null prototype] { event: [Function (anonymous)] },
  _eventsCount: 1,
  _maxListeners: undefined,
  [Symbol(shapeMode)]: false, // This line is added
  [Symbol(kCapture)]: false
} true

Refs: #50428

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Feb 29, 2024
@deokjinkim deokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 9930f11 into nodejs:main Mar 2, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9930f11

targos pushed a commit that referenced this pull request Mar 7, 2024
@deokjinkim @targos
doc: fix actual result of example is different in events
87d2acc 
Refs: #50428
PR-URL: #51925
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@targos targos mentioned this pull request Mar 7, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@deokjinkim @richardlau
doc: fix actual result of example is different in events
34edd42 
Refs: #50428
PR-URL: #51925
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@deokjinkim @richardlau
doc: fix actual result of example is different in events
fc0b389 
Refs: #50428
PR-URL: #51925
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 26, 2024
@deokjinkim @rdw-msft
doc: fix actual result of example is different in events
bea9c51 
Refs: nodejs#50428
PR-URL: nodejs#51925
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H4ad H4ad H4ad approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deokjinkim @nodejs-github-bot @lpinca @H4ad