lib,src: iterate module requests of a module wrap in JS #52058

legendecas · 2024-03-12T18:14:52Z

Avoid repetitively calling into JS callback from C++ in
ModuleWrap::Link. This removes the convoluted callback style of the
internal ModuleWrap link step.

Refs: #51977 (comment)

nodejs-github-bot · 2024-03-12T18:14:57Z

Review requested:

@nodejs/loaders
@nodejs/vm

lib/internal/modules/esm/module_job.js

nodejs-github-bot · 2024-03-22T07:55:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57894/

src/module_wrap.cc

test/es-module/test-esm-loader-concurrency.mjs

legendecas · 2024-04-14T22:54:58Z

Rebased on top of the tip of the main branch.

nodejs-github-bot · 2024-04-14T23:03:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58381/

nodejs-github-bot · 2024-04-15T21:01:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58413/

joyeecheung

General idea LGTM though this needs a rebase

joyeecheung · 2024-04-16T16:44:56Z

lib/internal/vm/module.js

-      assert.fail('link callback should not be called');
-    });
+  [kLink]() {
+    /** nothing to do for synthetic modules */


Doesn't need to be solved in this PR but it seems weird that we provide the link method for SyntheticModule at all....

Avoid repetitively calling into JS callback from C++ in `ModuleWrap::Link`. This removes the convoluted callback style of the internal `ModuleWrap` link step.

nodejs-github-bot · 2024-04-16T20:58:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58444/

nodejs-github-bot · 2024-04-17T08:48:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/58455/

legendecas · 2024-04-17T16:18:51Z

@joyeecheung thanks, rebased and CI is green.

joyeecheung

LGTM with a suggestion

joyeecheung · 2024-04-23T13:37:28Z

lib/internal/modules/esm/module_job.js

+    ObjectSetPrototypeOf(dependencyJobs, null);
+
+    // Specifiers should be aligned with the moduleRequests array in order.
+    const specifiers = Array(moduleRequests.length);


This leads to holey arrays, it might still be better to just use ArrayPrototyprPush since this is in a hot path (I think ArrayPrototypePush can be optimized properly the last time I checked).

Do you have a figure for it? As far as I can tell with the latest V8 version, using a microbenchmark to allocate a 20-length array with the two patterns, the result is outstanding that pre-allocating could be ~40% faster: https://jsbench.me/9tlvebajbe/1.

The problem with holey arrays come more from the access instead of the creation, since V8 needs to defend against things like this:

Array.prototype[1] = 1;
let a = Array(2);
a[1]; // 1

(Also, it's not blocking, I am fine landing with holey arrays, since it's probably still not that much work compared to all the other things the resolution is doing..)

Thanks for bringing this up. I think in this particular case the array is not accessed repetitively so I'd find pre-allocation would be a good solution here.

nodejs-github-bot · 2024-04-25T10:33:16Z

Landed in d5c7ffd

Avoid repetitively calling into JS callback from C++ in `ModuleWrap::Link`. This removes the convoluted callback style of the internal `ModuleWrap` link step. PR-URL: #52058 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Avoid repetitively calling into JS callback from C++ in `ModuleWrap::Link`. This removes the convoluted callback style of the internal `ModuleWrap` link step. PR-URL: nodejs#52058 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 12, 2024

legendecas marked this pull request as ready for review March 12, 2024 18:15

legendecas force-pushed the module/link branch 2 times, most recently from 26b9280 to b201582 Compare March 12, 2024 18:18

devsnek reviewed Mar 12, 2024

View reviewed changes

lib/internal/modules/esm/module_job.js Outdated Show resolved Hide resolved

legendecas force-pushed the module/link branch 2 times, most recently from c372b99 to 6daec91 Compare March 13, 2024 07:14

legendecas requested a review from joyeecheung March 18, 2024 17:06

legendecas force-pushed the module/link branch 2 times, most recently from a79c903 to 572d6b0 Compare March 19, 2024 03:02

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2024

joyeecheung reviewed Mar 22, 2024

View reviewed changes

src/module_wrap.cc Outdated Show resolved Hide resolved

src/module_wrap.cc Show resolved Hide resolved

src/module_wrap.cc Outdated Show resolved Hide resolved

src/module_wrap.cc Outdated Show resolved Hide resolved

joyeecheung reviewed Mar 22, 2024

View reviewed changes

test/es-module/test-esm-loader-concurrency.mjs Outdated Show resolved Hide resolved

legendecas force-pushed the module/link branch from 572d6b0 to 4cf26c3 Compare April 14, 2024 22:36

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2024

legendecas force-pushed the module/link branch from 4cf26c3 to 2c689f3 Compare April 14, 2024 22:55

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 14, 2024

legendecas force-pushed the module/link branch from 2c689f3 to ecf73ff Compare April 15, 2024 20:51

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2024

joyeecheung reviewed Apr 16, 2024

View reviewed changes

lib,src: iterate module requests of a module wrap in JS

9f615f1

Avoid repetitively calling into JS callback from C++ in `ModuleWrap::Link`. This removes the convoluted callback style of the internal `ModuleWrap` link step.

legendecas force-pushed the module/link branch from ecf73ff to 9f615f1 Compare April 16, 2024 20:52

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 16, 2024

joyeecheung approved these changes Apr 23, 2024

View reviewed changes

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024

nodejs-github-bot merged commit d5c7ffd into nodejs:main Apr 25, 2024
58 checks passed

legendecas deleted the module/link branch April 25, 2024 15:49

aduh95 mentioned this pull request Apr 30, 2024

2024-05-02, Version 22.1.0 (Current) #52768

Merged

joyeecheung mentioned this pull request Jun 17, 2024

module: support require()ing synchronous ESM graphs #51977

Closed

marco-ippolito added the backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. label Jul 19, 2024

joyeecheung mentioned this pull request Aug 23, 2024

Assigning a value to Array.prototype[1] will result in an error ：node:internal/process/task_queues:77 callback(); #54472

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib,src: iterate module requests of a module wrap in JS #52058

lib,src: iterate module requests of a module wrap in JS #52058

legendecas commented Mar 12, 2024 •

edited

Loading

nodejs-github-bot commented Mar 12, 2024

nodejs-github-bot commented Mar 22, 2024

legendecas commented Apr 14, 2024

nodejs-github-bot commented Apr 14, 2024

nodejs-github-bot commented Apr 15, 2024

joyeecheung left a comment

joyeecheung Apr 16, 2024

nodejs-github-bot commented Apr 16, 2024

nodejs-github-bot commented Apr 17, 2024

legendecas commented Apr 17, 2024

joyeecheung left a comment

joyeecheung Apr 23, 2024

legendecas Apr 24, 2024 •

edited

Loading

joyeecheung Apr 25, 2024

joyeecheung Apr 25, 2024

legendecas Apr 25, 2024 •

edited

Loading

nodejs-github-bot commented Apr 25, 2024

lib,src: iterate module requests of a module wrap in JS #52058

lib,src: iterate module requests of a module wrap in JS #52058

Conversation

legendecas commented Mar 12, 2024 • edited Loading

nodejs-github-bot commented Mar 12, 2024

nodejs-github-bot commented Mar 22, 2024

legendecas commented Apr 14, 2024

nodejs-github-bot commented Apr 14, 2024

nodejs-github-bot commented Apr 15, 2024

joyeecheung left a comment

Choose a reason for hiding this comment

joyeecheung Apr 16, 2024

Choose a reason for hiding this comment

nodejs-github-bot commented Apr 16, 2024

nodejs-github-bot commented Apr 17, 2024

legendecas commented Apr 17, 2024

joyeecheung left a comment

Choose a reason for hiding this comment

joyeecheung Apr 23, 2024

Choose a reason for hiding this comment

legendecas Apr 24, 2024 • edited Loading

Choose a reason for hiding this comment

joyeecheung Apr 25, 2024

Choose a reason for hiding this comment

joyeecheung Apr 25, 2024

Choose a reason for hiding this comment

legendecas Apr 25, 2024 • edited Loading

Choose a reason for hiding this comment

nodejs-github-bot commented Apr 25, 2024

legendecas commented Mar 12, 2024 •

edited

Loading

legendecas Apr 24, 2024 •

edited

Loading

legendecas Apr 25, 2024 •

edited

Loading