deps: update zlib to 1.3.0.1-motley-24c07df #52199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
dependencies
|
Review requested:
|
nodejs-github-bot
added
lib / src
github-actions
bot
removed
the
request-ci
marco-ippolito
approved these changes
Mar 24, 2024
|
@nodejs/platform-riscv64 @luyahan riscv64 is not yet a supported platform so I think it does not make sense to enable the optimizations. |
lpinca
approved these changes
Mar 24, 2024
marco-ippolito
added
the
author ready
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 38161c3 |
|
@nodejs/platform-riscv64 Does this risk any problems on TH1520 and similar systems which do not have the final 1.0 version of RVV but may advertise themselves as having that capability? |
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52199 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52199 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
May 16, 2024
PR-URL: #52199 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of zlib to 1.3.0.1-motley-24c07df.