doc, test: clarify the behavior of todo tests #52204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a regression test for the edge case where a test runner test is marked as both todo and skip. Refs: nodejs#49013
|
Review requested:
|
atlowChemi
reviewed
Mar 24, 2024
This commit adds a section to the test runner docs explaining what a TODO test is. Refs: nodejs#49013
|
@atlowChemi thanks for the review. I have updated the PR based on your comments. |
cjihrig
added
the
commit-queue-rebase
atlowChemi
approved these changes
Mar 25, 2024
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Mar 25, 2024
cjihrig
added
author ready
MoLow
approved these changes
Mar 26, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 312ebd9...fa13ed6 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
This commit adds a regression test for the edge case where a test runner test is marked as both todo and skip. Refs: nodejs#49013 PR-URL: nodejs#52204 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
This commit adds a section to the test runner docs explaining what a TODO test is. Refs: nodejs#49013 PR-URL: nodejs#52204 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: add test for skip+todo combinations
This commit adds a regression test for the edge case where a
test runner test is marked as both todo and skip.
Refs: #49013
doc: add section explaining todo tests
This commit adds a section to the test runner docs explaining
what a TODO test is.
Refs: #49013