Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc cleanup #5233

Closed
wants to merge 3 commits into from
Closed

misc cleanup #5233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ad8e5a
src: remove unnecessary check
mscdex Feb 15, 2016
5875b0c
http: remove unnecessary check
mscdex Feb 15, 2016
6da8293
http: remove old, confusing comment
mscdex Feb 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/_http_incoming.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ exports.readStop = readStop;
function IncomingMessage(socket) {
Stream.Readable.call(this);

// XXX This implementation is kind of all over the place
// When the parser emits body chunks, they go in this list.
// _read() pulls them out, and when it finds EOF, it ends.

this.socket = socket;
this.connection = socket;

Expand Down
3 changes: 1 addition & 2 deletions lib/_http_outgoing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,8 +489,7 @@ function writeAfterEndNT(self, err, callback) {


function connectionCorkNT(conn) {
if (conn)
conn.uncork();
conn.uncork();
}


Expand Down
1 change: 0 additions & 1 deletion src/env-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ inline Environment::AsyncCallbackScope::AsyncCallbackScope(Environment* env)

inline Environment::AsyncCallbackScope::~AsyncCallbackScope() {
env_->makecallback_cntr_--;
CHECK_GE(env_->makecallback_cntr_, 0);
}

inline bool Environment::AsyncCallbackScope::in_makecallback() {
Expand Down