-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vm: fix ASCII-betical order #52686
Merged
Merged
vm: fix ASCII-betical order #52686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
PRs that need a full CI run.
vm
Issues and PRs related to the vm subsystem.
labels
Apr 25, 2024
avivkeller
added
fast-track
PRs that do not need to wait for 48 hours to land.
and removed
vm
Issues and PRs related to the vm subsystem.
needs-ci
PRs that need a full CI run.
labels
Apr 25, 2024
Fast-track has been requested by @redyetidev. Please 👍 to approve. |
avivkeller
added
vm
Issues and PRs related to the vm subsystem.
needs-ci
PRs that need a full CI run.
labels
Apr 25, 2024
richardlau
approved these changes
Apr 25, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Apr 25, 2024
lpinca
approved these changes
Apr 25, 2024
legendecas
approved these changes
Apr 25, 2024
avivkeller
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Apr 25, 2024
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 25, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Apr 25, 2024
Landed in 1728203 |
aduh95
pushed a commit
that referenced
this pull request
Apr 29, 2024
PR-URL: #52686 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
May 21, 2024
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52686 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
fast-track
PRs that do not need to wait for 48 hours to land.
needs-ci
PRs that need a full CI run.
vm
Issues and PRs related to the vm subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an ASCII-betical issue.
Requesting
fast-track
as this prevents lint from passing on current builds.