Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: fix ASCII-betical order #52686

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

avivkeller
Copy link
Member

This PR fixes an ASCII-betical issue.

Requesting fast-track as this prevents lint from passing on current builds.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Apr 25, 2024
@avivkeller avivkeller added fast-track PRs that do not need to wait for 48 hours to land. and removed vm Issues and PRs related to the vm subsystem. needs-ci PRs that need a full CI run. labels Apr 25, 2024
Copy link
Contributor

Fast-track has been requested by @redyetidev. Please 👍 to approve.

@avivkeller avivkeller added vm Issues and PRs related to the vm subsystem. needs-ci PRs that need a full CI run. labels Apr 25, 2024
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@avivkeller avivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit 1728203 into nodejs:main Apr 25, 2024
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1728203

@avivkeller avivkeller deleted the patch-2 branch April 25, 2024 19:15
aduh95 pushed a commit that referenced this pull request Apr 29, 2024
PR-URL: #52686
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label May 21, 2024
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
PR-URL: nodejs#52686
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants