deps, src: simplifying base64 encoding #52714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dependencies
lemire
force-pushed
the
simplifying_base64_encoding
branch
2 times, most recently
from
280494e to
8297c11
Compare
anonrig
reviewed
Apr 26, 2024
richardlau
added
the
baking-for-lts
anonrig
approved these changes
Apr 26, 2024
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
marco-ippolito
removed
the
author ready
|
Awesome! Nit: I think the commit message needs to be amended to start with an imperative verb, according to the guidelines. |
lemire
force-pushed
the
simplifying_base64_encoding
branch
from
842e9e1 to
7a07c7e
Compare
Fixed. |
github-actions
bot
removed
the
request-ci
targos
requested changes
Apr 28, 2024
|
@targos Good catch! Ran it. |
BridgeAR
approved these changes
Apr 29, 2024
marco-ippolito
approved these changes
Apr 29, 2024
Commit Queue failed- Loading data for nodejs/node/pull/52714 ✔ Done loading data for nodejs/node/pull/52714 ----------------------------------- PR info ------------------------------------ Title deps, src: simplifying base64 encoding (#52714) Author Daniel Lemire (@lemire) Branch lemire:simplifying_base64_encoding -> nodejs:main Labels tools, baking-for-lts, needs-ci, dependencies Commits 2 - deps,src: simplify base64 encoding - fix: tools/license-builder.sh Committers 1 - Daniel Lemire PR-URL: https://github.com/nodejs/node/pull/52714 Reviewed-By: Yagiz Nizipli Reviewed-By: Moshe Atlow Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: Marco Ippolito ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52714 Reviewed-By: Yagiz Nizipli Reviewed-By: Moshe Atlow Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: Marco Ippolito -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 26 Apr 2024 19:15:25 GMT ✔ Approvals: 5 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52714#pullrequestreview-2025987672 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52714#pullrequestreview-2026906558 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/52714#pullrequestreview-2028772611 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/52714#pullrequestreview-2028491743 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52714#pullrequestreview-2028604304 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-04-28T06:18:56Z: https://ci.nodejs.org/job/node-test-pull-request/58770/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - fix: tools/license-builder.sh - Querying data for job/node-test-pull-request/58770/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/8881428267 |
richardlau
approved these changes
Apr 29, 2024
richardlau
added
commit-queue
github-actions
bot
removed
the
request-ci
marco-ippolito
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6aa9047 |
aduh95
pushed a commit
that referenced
this pull request
Apr 30, 2024
PR-URL: #52714 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Ch3nYuY
pushed a commit
to Ch3nYuY/node
that referenced
this pull request
May 8, 2024
PR-URL: nodejs#52714 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Jun 13, 2024
The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: nodejs#52714
|
When this lands in LTS, it should land with the fixup for |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 15, 2024
The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: #52714 PR-URL: #53442 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: #52714 PR-URL: #53442 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52714 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: nodejs#52714 PR-URL: nodejs#53442 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52714 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
The `base64` dependency was previously removed along with the update script (`tools/dep_updaters/update-base64.sh`) but the generated header, `src/base64_version.h` was left behind and `process.versions` was still listing the last version of `base64` that was included in Node.js before it was removed Refs: nodejs#52714 PR-URL: nodejs#53442 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following recent work by @anonrig, we no longer have use for existing base64 encoding code. This PR, if merged, will drop much of the base64 encoding code.
It should be otherwise inconsequential.