Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watch: fix arguments parsing #52760

Merged
merged 6 commits into from
May 2, 2024
Merged

watch: fix arguments parsing #52760

merged 6 commits into from
May 2, 2024

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Apr 30, 2024 •
edited
Loading

Fixes #52704

@MoLow MoLow requested review from benjamingr and rluvaton April 30, 2024 15:27
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 30, 2024
@MoLow MoLow added the watch-mode Issues and PRs related to watch mode label Apr 30, 2024
rluvaton
rluvaton approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@rluvaton rluvaton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add another test for single letter flag as well (e.g. -r)

@MoLow
Copy link
Member Author

MoLow commented May 1, 2024

@rluvaton added. can you please re-approve?

@MoLow MoLow requested a review from rluvaton May 1, 2024 10:18
@MoLow MoLow requested a review from rluvaton May 1, 2024 11:16
@rluvaton rluvaton added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58833/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58836/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58853/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58855/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58859/

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2024
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 2, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/52760
✔  Done loading data for nodejs/node/pull/52760
----------------------------------- PR info ------------------------------------
Title      watch: fix arguments parsing (#52760)
Author     Moshe Atlow  (@MoLow)
Branch     MoLow:fix-watch-mode-args -> nodejs:main
Labels     author ready, needs-ci, watch-mode
Commits    6
 - watch: fix arguments parsing
 - CR
 - fix test
 - fix test
 - CR
 - CR
Committers 1
 - Moshe Atlow 
PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52760
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 30 Apr 2024 15:27:18 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52760#pullrequestreview-2031899284
   ✔  - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/52760#pullrequestreview-2033469033
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-05-02T10:19:49Z: https://ci.nodejs.org/job/node-test-pull-request/58859/
- Querying data for job/node-test-pull-request/58859/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 52760
From https://github.com/nodejs/node
 * branch                  refs/pull/52760/merge -> FETCH_HEAD
✔  Fetched commits as 08c3256527eb..4a23ab6af99e
--------------------------------------------------------------------------------
[main 162b20f0cb] watch: fix arguments parsing
 Author: Moshe Atlow 
 Date: Tue Apr 30 18:14:21 2024 +0300
 2 files changed, 20 insertions(+), 3 deletions(-)
[main e53d773384] CR
 Author: Moshe Atlow 
 Date: Tue Apr 30 18:34:50 2024 +0300
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 91d872af21] fix test
 Author: Moshe Atlow 
 Date: Tue Apr 30 19:28:05 2024 +0300
 1 file changed, 2 insertions(+), 2 deletions(-)
[main 3f8e7cf369] fix test
 Author: Moshe Atlow 
 Date: Tue Apr 30 19:31:25 2024 +0300
 1 file changed, 4 insertions(+), 2 deletions(-)
[main eabb33cc91] CR
 Author: Moshe Atlow 
 Date: Wed May 1 13:17:19 2024 +0300
 1 file changed, 26 insertions(+), 1 deletion(-)
[main 85dab0edeb] CR
 Author: Moshe Atlow 
 Date: Wed May 1 14:16:05 2024 +0300
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 6 commits in the PR. Attempting autorebase.
Rebasing (2/12)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

watch: fix arguments parsing


PR-URL: #52760

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Raz Luvaton rluvaton@gmail.com


[detached HEAD 71fb278ffd] watch: fix arguments parsing

Author: Moshe Atlow moshe@atlow.co.il

Date: Tue Apr 30 18:14:21 2024 +0300

2 files changed, 20 insertions(+), 3 deletions(-)

Rebasing (3/12)

Rebasing (4/12)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

CR


PR-URL: #52760

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Raz Luvaton rluvaton@gmail.com


[detached HEAD 1ed3f345a7] CR

Author: Moshe Atlow moshe@atlow.co.il

Date: Tue Apr 30 18:34:50 2024 +0300

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (5/12)

Rebasing (6/12)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix test


PR-URL: #52760

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Raz Luvaton rluvaton@gmail.com


[detached HEAD 9db47ed615] fix test

Author: Moshe Atlow moshe@atlow.co.il

Date: Tue Apr 30 19:28:05 2024 +0300

1 file changed, 2 insertions(+), 2 deletions(-)

Rebasing (7/12)

Rebasing (8/12)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fix test


PR-URL: #52760

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Raz Luvaton rluvaton@gmail.com


[detached HEAD 0575ab69a9] fix test

Author: Moshe Atlow moshe@atlow.co.il

Date: Tue Apr 30 19:31:25 2024 +0300

1 file changed, 4 insertions(+), 2 deletions(-)

Rebasing (9/12)

Rebasing (10/12)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

CR


PR-URL: #52760

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Raz Luvaton rluvaton@gmail.com


[detached HEAD 4d934d5fb6] CR

Author: Moshe Atlow moshe@atlow.co.il

Date: Wed May 1 13:17:19 2024 +0300

1 file changed, 26 insertions(+), 1 deletion(-)

Rebasing (11/12)

Rebasing (12/12)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

CR


PR-URL: #52760

Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com

Reviewed-By: Raz Luvaton rluvaton@gmail.com


[detached HEAD 95bc1a63b5] CR

Author: Moshe Atlow moshe@atlow.co.il

Date: Wed May 1 14:16:05 2024 +0300

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/8926528811

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 905ab3e into nodejs:main May 2, 2024
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 905ab3e

Whitecx pushed a commit to Whitecx/node that referenced this pull request May 2, 2024
@MoLow @Whitecx
watch: fix arguments parsing
ee5c037 
PR-URL: nodejs#52760
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@MoLow MoLow deleted the fix-watch-mode-args branch May 2, 2024 21:20
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@MoLow
watch: fix arguments parsing
7b048f7 
PR-URL: nodejs#52760
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
targos pushed a commit that referenced this pull request May 8, 2024
@MoLow @targos
watch: fix arguments parsing
f5d9257 
PR-URL: #52760
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@targos targos mentioned this pull request May 13, 2024
Merged
@jakecastelli jakecastelli mentioned this pull request May 26, 2024
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@MoLow @marco-ippolito
watch: fix arguments parsing
739adf9 
PR-URL: #52760
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@MoLow @sophoniie
watch: fix arguments parsing
5aeea0b 
PR-URL: nodejs#52760
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@MoLow @bmeck
watch: fix arguments parsing
b6703b6 
PR-URL: nodejs#52760
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluvaton rluvaton rluvaton approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees

@MoLow MoLow

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inspector not starting with --watch flag before
4 participants
@MoLow @nodejs-github-bot @benjamingr @rluvaton