doc: fix buf.readInt16LE output #5282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous example didn't account for the 1 byte offset
| @@ -728,7 +728,7 @@ const buf = new Buffer([1,-2,3,4]); | |||
| buf.readInt16BE(); | |||
| // returns 510 | |||
| buf.readInt16LE(1); | |||
| // returns -511 | |||
| // returns 1022 | |||
There was a problem hiding this comment.
I think the original intent was to read the same two bytes.
cc @jasnell who I believe added this example.
There was a problem hiding this comment.
Gotcha. Will update to whatever @jasnell thinks here
There was a problem hiding this comment.
Yep, this was a typo on my part... the second one should be buf.readInt16LE(); (no argument passed in)
There was a problem hiding this comment.
that said, this change works too
mscdex
added
buffer
|
LGTM |
|
LGTM, landed in 8b1af2f. |
silverwind
pushed a commit
that referenced
this pull request
Feb 25, 2016
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 17, 2016
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Previous example didn't account for the 1 byte offset PR-URL: #5282 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.