test: unskip v8-updates/test-linux-perf-logger #52869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lukealbao
changed the title
targos
approved these changes
May 7, 2024
targos
added
dont-land-on-v18.x
lpinca
approved these changes
May 7, 2024
|
richardlau
approved these changes
May 7, 2024
daeyeon
approved these changes
May 7, 2024
github-actions
bot
removed
the
request-ci
richardlau
added
commit-queue
|
Landed in c0c598d...4ef5bc1. |
Merged
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
Refs: nodejs#51308 Refs: nodejs#52821 PR-URL: nodejs#52869 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
This reverts commit 54f1e0a. PR-URL: nodejs#52869 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Refs: nodejs#51308 Refs: nodejs#52821 PR-URL: nodejs#52869 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
This reverts commit 54f1e0a. PR-URL: nodejs#52869 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes #51308. It includes commit to re-enable the test by reverting #52821.
Explanation
This test suite is a dependency-free port of
test/v8-updates/test-linux-perf.js. In both cases, js code is evaluated in a child process with v8 options set to emit a symbol table forperf(1). Verification is done by regex lookup. In the output, a functionfoowill be distinguished as compiled or interpreted based on a unary prefix character. Test cases use v8 option arguments to the child process to ensure compilation when applicable.In 2023 (I don't know how to identify the release version), v8 added a new additional flag to guard optimization (link). This patch includes that in the child process options.