src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv #52905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
RafaelGSS
force-pushed
the
disable-external-module
branch
from
fce6acc to
c031cfb
Compare
|
IMO if it's a breaking change it should be semver-minor or notable-change (But as a triage member, this isn't my decision, nor my place) |
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/9008046172 |
RafaelGSS
removed
the
request-ci-failed
Trott
approved these changes
May 14, 2024
Trott
reviewed
May 14, 2024
Comment on lines
+2783
to
+2853
| changes: | ||
| - version: | ||
| - REPLACEME | ||
| pr-url: https://github.com/nodejs/node/pull/52905 | ||
| description: | ||
| Remove the possibility to use this env var with | ||
| kDisableNodeOptionsEnv for embedders. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Actually, with a little more thought, I think this is semver patch, so I agree with @RafaelGSS. But I'll defer to Releasers who think otherwise or collaborators more knowledgable about how these features are used. |
github-actions
bot
removed
the
request-ci
Whatever you say I'm happy with, I'm not a collaborator, so I really don't have much of an opinion (and experience) to really weigh in |
github-actions
bot
removed
the
request-ci
RafaelGSS
force-pushed
the
disable-external-module
branch
from
ccfa477 to
0b16434
Compare
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/52905 ✔ Done loading data for nodejs/node/pull/52905 ----------------------------------- PR info ------------------------------------ Title src: sync NODE_REPL_EXTERNAL_MODULE and kDisableNodeOptionsEnv (#52905) Author Rafael Gonzaga (@RafaelGSS) Branch RafaelGSS:disable-external-module -> nodejs:main Labels c++, repl, author ready, needs-ci, commit-queue-squash Commits 2 - src: fix external module env and kDisableNodeOptionsEnv - fixup! src: fix external module env and kDisableNodeOptionsEnv Committers 1 - RafaelGSS PR-URL: https://github.com/nodejs/node/pull/52905 Fixes: https://github.com/nodejs/node/issues/51227 Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52905 Fixes: https://github.com/nodejs/node/issues/51227 Reviewed-By: Rich Trott Reviewed-By: Joyee Cheung -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - fixup! src: fix external module env and kDisableNodeOptionsEnv ℹ This PR was created on Wed, 08 May 2024 17:55:32 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott): https://github.com/nodejs/node/pull/52905#pullrequestreview-2056494543 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/52905#pullrequestreview-2069699196 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-22T14:10:03Z: https://ci.nodejs.org/job/node-test-pull-request/59352/ - Querying data for job/node-test-pull-request/59352/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9200620708 |
juanarbol
approved these changes
May 23, 2024
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b9ad94b |
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
May 27, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: nodejs#52905 Refs: nodejs#52646
StefanStojanovic
added a commit
to JaneaSystems/node
that referenced
this pull request
May 27, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: nodejs#52905 Refs: nodejs#52646
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 27, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: #52905 Refs: #52646 PR-URL: #53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: #52905 Refs: #52646 PR-URL: #53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#52905 Fixes: nodejs#51227 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: nodejs#52905 Refs: nodejs#52646 PR-URL: nodejs#53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#52905 Fixes: nodejs#51227 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: nodejs#52905 Refs: nodejs#52646 PR-URL: nodejs#53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: #52905 Refs: #52646 PR-URL: #53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
2 PRs that landed independently caused this issue which makes every native suites run in CI fail on Windows. This is just a quick patch to unblock the CI. Refs: #52905 Refs: #52646 PR-URL: #53173 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51227
Currently, I'm throwing kBootstrapError, but I'm almost sure this is not the appropriate error. In this case, should I create a new error?
Technically, this is a fix for
kDisableNodeOptionsEnv, but it can be considered a breaking change for the ones relying on the current behavior (which is unlikely).