Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,doc: replace references to import assertions #52998

Merged
merged 1 commit into from
May 17, 2024
Merged

lib,doc: replace references to import assertions #52998

merged 1 commit into from
May 17, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 15, 2024

Use "import attributes" and "type attribute" instead.

@targos
lib,doc: replace references to import assertions
dfba080 
Use "import attributes" and "type attribute" instead.
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels May 15, 2024
@targos targos mentioned this pull request May 15, 2024
Closed
@targos targos linked an issue May 15, 2024 that may be closed by this pull request
Prefer "import attributes" to "import assertions" #52995
Closed
@targos
Copy link
Member Author

targos commented May 15, 2024

@nodejs/loaders

@avivkeller avivkeller added doc Issues and PRs related to the documentations. loaders Issues and PRs related to ES module loaders labels May 15, 2024
@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau richardlau added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels May 15, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59236/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2024
@nodejs-github-bot nodejs-github-bot merged commit fac55e3 into nodejs:main May 17, 2024
78 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fac55e3

@targos targos deleted the assertions branch May 17, 2024 08:57
targos added a commit that referenced this pull request May 21, 2024
@targos
lib,doc: replace references to import assertions
879679e 
Use "import attributes" and "type attribute" instead.

PR-URL: #52998
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@targos @sophoniie
lib,doc: replace references to import assertions
03d65af 
Use "import attributes" and "type attribute" instead.

PR-URL: nodejs#52998
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@targos @bmeck
lib,doc: replace references to import assertions
c141dc9 
Use "import attributes" and "type attribute" instead.

PR-URL: nodejs#52998
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos removed lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels Sep 21, 2024
@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@aduh95 aduh95 aduh95 approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefer "import attributes" to "import assertions"
8 participants
@targos @nodejs-github-bot @GeoffreyBooth @aduh95 @VoltrexKeyva @atlowChemi @richardlau @avivkeller