Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "src: make sure pass the argv to worker threads" #53021

Closed
wants to merge 2 commits into from
Closed

Revert "src: make sure pass the argv to worker threads" #53021

wants to merge 2 commits into from

Commits on May 16, 2024

  1. worker: add test for env option when using process-only cli flag 

    It should be possible to pass the `env` option to a worker
even when the parent process is using a process-level flag, such
as `--title` or a V8-specific flag.

This test is currently failing in Node.js 22.2.0
    @nicolo-ribaudo
    nicolo-ribaudo committed May 16, 2024
    Configuration menu
    Copy the full SHA
    cc4e8f2 View commit details
    Browse the repository at this point in the history

  2. Revert "src: make sure pass the argv to worker threads" 

    This reverts commit aba4a00.
    @nicolo-ribaudo
    nicolo-ribaudo committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e05e072 View commit details
    Browse the repository at this point in the history