-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update repo docs to use 'CTC' #5304
Conversation
LGTM |
Rubber-stamp LGTM |
@@ -1,11 +1,11 @@ | |||
# Node.js Working Groups | |||
|
|||
Node.js Working Groups are autonomous projects created by the | |||
[Technical Steering Committee (TSC)](https://github.com/nodejs/node/blob/master/GOVERNANCE.md#technical-committee). | |||
[Core Technical Committee (CTC)](https://github.com/nodejs/node/blob/master/GOVERNANCE.md#core-technical-committee). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, if I understand correctly CTC is purely a technical body. So this should be TSC only I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm right, more language needs to be updated. Technically it is the CTC that charters WG's to work on core, but this probably is still outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean, it doesn't contemplate that WGs can be created at the TSC level too? How about if we renamed this section to "Node.js Core Working Groups"? Not sure if we need to mention here that there is a level above Core (TSC and TSC chartered WGs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Node.js Core Working Groups"?
That could work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have non-core work groups right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There exist non-core Working Groups in the Node.js Foundation, which report to the TSC. There can also be other working groups that report to other Top Level Projects (e.g. Express or libuv).
I don't think it's strictly necessary for this doc to describe the whole hierarchy, and things that it doesn't have a governance over, though it could certainly be improved (perhaps with a link). Maybe room for another PR? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Thanks for clarifying :)
5c04d26
to
bca58f9
Compare
Updated WORKING_GROUPS.md to refer to working groups as "Node.js Core Working Groups" in the title and first sentence of the doc. |
FYI @nodejs/ctc |
Lgtm |
PR-URL: #5304 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed with 18abb3c. Thank you. |
PR-URL: #5304 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #5304 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #5304 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #5304 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
No description provided.