test: replace .substr with .slice
#53070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com>
nodejs-github-bot
added
esm
aduh95
added
request-ci
github-actions
bot
removed
the
request-ci
targos
approved these changes
May 20, 2024
trivikr
approved these changes
May 20, 2024
benjamingr
approved these changes
May 20, 2024
lpinca
approved these changes
May 20, 2024
anonrig
approved these changes
May 21, 2024
juanarbol
approved these changes
May 21, 2024
MoLow
approved these changes
May 21, 2024
|
I return the question: why do you think we should use |
aduh95
added
author ready
|
Fast-track has been requested by @targos. Please 👍 to approve. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53070 ✔ Done loading data for nodejs/node/pull/53070 ----------------------------------- PR info ------------------------------------ Title test: replace `.substr` with `.slice` (#53070) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:sub-substr -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: replace `.substr` with `.slice` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/53070 Reviewed-By: Michaël Zasso Reviewed-By: Trivikram Kamat Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53070 Reviewed-By: Michaël Zasso Reviewed-By: Trivikram Kamat Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda Reviewed-By: Moshe Atlow -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 May 2024 11:21:02 GMT ✔ Approvals: 7 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066181127 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066321383 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066494050 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066592235 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067271445 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067536710 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067888793 ℹ This PR is being fast-tracked ✘ This PR needs to wait 22 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-20T11:26:29Z: https://ci.nodejs.org/job/node-test-pull-request/59311/ - Querying data for job/node-test-pull-request/59311/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9174979544 |
bnb
approved these changes
May 21, 2024
bnb
added
commit-queue
|
requeued (?) since it was only missing a 👍🏻 on the fast track |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53070 ✔ Done loading data for nodejs/node/pull/53070 ----------------------------------- PR info ------------------------------------ Title test: replace `.substr` with `.slice` (#53070) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:sub-substr -> nodejs:main Labels test, fast-track, author ready, needs-ci Commits 1 - test: replace `.substr` with `.slice` Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/53070 Reviewed-By: Michaël Zasso Reviewed-By: Trivikram Kamat Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda Reviewed-By: Moshe Atlow Reviewed-By: Tierney Cyren ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53070 Reviewed-By: Michaël Zasso Reviewed-By: Trivikram Kamat Reviewed-By: Benjamin Gruenbaum Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda Reviewed-By: Moshe Atlow Reviewed-By: Tierney Cyren -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 20 May 2024 11:21:02 GMT ✔ Approvals: 8 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066181127 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066321383 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066494050 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53070#pullrequestreview-2066592235 ✔ - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067271445 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067536710 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/53070#pullrequestreview-2067888793 ✔ - Tierney Cyren (@bnb): https://github.com/nodejs/node/pull/53070#pullrequestreview-2069078323 ℹ This PR is being fast-tracked ✘ GitHub CI is still running ℹ Last Full PR CI on 2024-05-21T12:51:22Z: https://ci.nodejs.org/job/node-test-pull-request/59311/ - Querying data for job/node-test-pull-request/59311/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9177998933 |
tniessen
approved these changes
May 21, 2024
targos
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4a54a80 |
This comment was marked as off-topic.
This comment was marked as off-topic.
targos
added a commit
that referenced
this pull request
Jun 1, 2024
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: #53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: nodejs#53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: nodejs#53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: #53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
`String.prototype.substr` is deprecated, and using it will raise an error when using ESLint 9+. Co-authored-by: =?UTF-8?q?Micha=C3=ABl=20Zasso?= <targos@protonmail.com> PR-URL: #53070 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.prototype.substris deprecated, and using it will raise an error when using ESLint 9+ (#52780).