Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm,src: add property query interceptors #53172

Merged
merged 2 commits into from
Jun 4, 2024
Merged

vm,src: add property query interceptors #53172

merged 2 commits into from
Jun 4, 2024

Conversation

targos
Copy link
Member

@targos targos commented May 27, 2024

Fixes: #52720

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels May 27, 2024
@targos
Copy link
Member Author

targos commented May 27, 2024

/cc @nodejs/cpp-reviewers

@targos targos mentioned this pull request May 27, 2024
Closed
@targos
Copy link
Member Author

targos commented May 28, 2024

@nodejs/vm

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59488/

@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 28, 2024
@targos
Copy link
Member Author

targos commented Jun 1, 2024

Can someone else please review?

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2024
@nodejs-github-bot nodejs-github-bot merged commit d1f18b0 into nodejs:main Jun 4, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d1f18b0

@targos targos deleted the fix-52720 branch June 4, 2024 06:55
@tsctx tsctx mentioned this pull request Jun 5, 2024
Closed
@targos targos added the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Jun 5, 2024
@targos targos mentioned this pull request Jun 5, 2024
Merged
@legendecas legendecas mentioned this pull request Jun 20, 2024
Closed
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@targos @eliphazbouye
vm,src: add property query interceptors
b8fbf34 
Fixes: nodejs#52720
PR-URL: nodejs#53172
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@targos @bmeck
vm,src: add property query interceptors
234ef2a 
Fixes: nodejs#52720
PR-URL: nodejs#53172
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent presence of property in contextified object
3 participants
@targos @nodejs-github-bot @joyeecheung