lib: fix the name of the fetch global function

[dygabo]

this fixes a small regression introduced with #52275

the global.fetch.name should be fetch instead of value. That is also the name that the inspector gets and what is shown implicitly on the call stack during debugging. With this change global.fetch will be shown on the call stack instead of global.value.
Added a generic test to ensure the same applies to all the global functions.

[nodejs-github-bot]

Review requested:

• @nodejs/startup
• @nodejs/web-standards

[avivkeller]

LGTM!

Tip

I am not a core collaborator, so while this review shows my support, it doesn't have much power

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59563/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59572/

[aduh95]

Related test failure:

not ok 1365 parallel/test-global
  ---
  duration_ms: 110.76200
  severity: fail
  exitcode: 1
  stack: |-
    node:internal/bootstrap/web/exposed-window-or-worker:121
                               throw new ERR_NO_CRYPTO();
                               ^
    
    Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support
        at get crypto (node:internal/bootstrap/web/exposed-window-or-worker:121:34)
        at /home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-global.js:65:22
        at Array.forEach (<anonymous>)
        at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-global.js:64:12)
        at Module._compile (node:internal/modules/cjs/loader:1460:14)
        at Module._extensions..js (node:internal/modules/cjs/loader:1544:10)
        at Module.load (node:internal/modules/cjs/loader:1275:32)
        at Module._load (node:internal/modules/cjs/loader:1091:12)
        at wrapModuleLoad (node:internal/modules/cjs/loader:212:19)
        at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:158:5) {
      code: 'ERR_NO_CRYPTO'
    }
    
    Node.js v23.0.0-pre
  ...

[aduh95]

Node.js collaborators, please do not resume CI without checking if test failures are related, otherwise the flakiness of the CI is only going to get worse.

[dygabo]

Related test failure:

not ok 1365 parallel/test-global
  ---

@aduh95 I pushed a fix for that to throw if the function is called, not if the property is being looked at. I preferred that over allowing the exception in the test but please let me know what you think.

[aduh95]

@dygabo I don't think this is correct, Object.getOwnPropertyDescriptor(globalThis, 'crypto').get.name should be the string 'get crypto', which won't be true anymore with your last commit IIUC.

[dygabo]

@dygabo I don't think this is correct, Object.getOwnPropertyDescriptor(globalThis, 'crypto').get.name should be the string 'get crypto', which won't be true anymore with your last commit IIUC.

what would be the correct behaviour then to cover this? Only test for the name of fetch? or allow the exception in the test? Or make just the code change and don't add the test as that is new and does not seem it was needed until now?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59594/

[nodejs-github-bot]

Landed in 6671911