stream: prevent stream unexpected pause when highWaterMark set to 0 #53261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
I tend to agree with @ronag on highWaterMark set to 0 does not make much sense but I guess that will be a sermver-major? |
Co-authored-by: Robert Nagy <ronagy@icloud.com>
|
See also whatwg/streams#1158 (I'm not sure what the conclusion is there, long read). |
benjamingr
approved these changes
Jun 2, 2024
github-actions
bot
removed
the
request-ci
H4ad
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 50695e5 |
sophonieb
pushed a commit
to sophonieb/node
that referenced
this pull request
Jun 20, 2024
Co-authored-by: Robert Nagy <ronagy@icloud.com> PR-URL: nodejs#53261 Fixes: nodejs#51930 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Co-authored-by: Robert Nagy <ronagy@icloud.com> PR-URL: nodejs#53261 Fixes: nodejs#51930 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51930
p.s. I noticed that the bot knows to require review from the correct team but the label
streamisn't added 👀