tools: remove no-goma arg from make-v8 script #53336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
V8 recently removed its support and passing it makes canary builds fail. It should be safe to remove it now as the default behavior is to look for goma in the PATH, and CI hosts shouldn't have goma installed. Refs: v8/v8@6c5a6c0
nodejs-github-bot
added
needs-ci
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as duplicate.
|
Do we need to remove the goma related options from the other (s390x/ppc64le) branch? |
|
I don't know. Here is the V8 CI that failed for the canary branch: https://ci.nodejs.org/job/node-test-commit-v8-linux/6020/ |
richardlau
approved these changes
Jun 4, 2024
It looks like for now we get a warning but not a failure: 12:30:13 WARNING at the command-line "--args":1:65: Build argument has no effect.
12:30:13 is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x" v8_enable_backtrace=true cc_wrapper="ccache"
12:30:13 ^-----
12:30:13 The variable "goma_dir" was set as a build argument
12:30:13 but never appeared in a declare_args() block in any buildfile.
12:30:13
12:30:13 To view all possible args, run "gn args --list <out_dir>"
12:30:13
12:30:13 The build continued as if that argument was unspecified.
12:30:13
12:30:13 Build graph constructed in 209ms
12:30:13 Done. Made 520 targets from 128 files in 212ms |
joyeecheung
approved these changes
Jun 5, 2024
lpinca
approved these changes
Jun 5, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 68c9f55 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 7, 2024
V8 recently removed its support and passing it makes canary builds fail. It should be safe to remove it now as the default behavior is to look for goma in the PATH, and CI hosts shouldn't have goma installed. Refs: v8/v8@6c5a6c0 PR-URL: #53336 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
V8 recently removed its support and passing it makes canary builds fail. It should be safe to remove it now as the default behavior is to look for goma in the PATH, and CI hosts shouldn't have goma installed. Refs: v8/v8@6c5a6c0 PR-URL: nodejs#53336 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
V8 recently removed its support and passing it makes canary builds fail. It should be safe to remove it now as the default behavior is to look for goma in the PATH, and CI hosts shouldn't have goma installed. Refs: v8/v8@6c5a6c0 PR-URL: nodejs#53336 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
V8 recently removed its support and passing it makes canary builds fail. It should be safe to remove it now as the default behavior is to look for goma in the PATH, and CI hosts shouldn't have goma installed. Refs: v8/v8@6c5a6c0 PR-URL: #53336 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
V8 recently removed its support and passing it makes canary builds fail. It should be safe to remove it now as the default behavior is to look for goma in the PATH, and CI hosts shouldn't have goma installed. Refs: v8/v8@6c5a6c0 PR-URL: #53336 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 recently removed its support and passing it makes canary builds fail. It should be safe to remove it now as the default behavior is to look for goma in the PATH, and CI hosts shouldn't have goma installed.
Refs: v8/v8@6c5a6c0
@nodejs/v8-update