Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark --cpu-prof and --heap-prof as stable #53343

Closed
wants to merge 2 commits into from
Closed

doc: mark --cpu-prof and --heap-prof as stable #53343

wants to merge 2 commits into from

Conversation

joyeecheung
Copy link
Member

As far as I remember the reason for keeping them experimental was to leave some room to allow (potentially breaking) customization of directories and profile name patterns. But at this point it seems the --diagnostic-dir option that controls the default directory works well enough for the first case, and profile name patterns are part of a bigger issue of name patterns for many other outputs (reports, traces, etc.) and I expect any breaking changes will need to be semver-major together with other stable features that would share the same customization. So there is not really any point to keep them experimental (also, I believe they have been used enough in the wild that it may be unwise to break them without going semver-major at this point). So this PR just marks them as stable since that's already the reality.

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Jun 5, 2024
@joyeecheung
Copy link
Member Author

I believe the process requires pinging the TSC when changing the stability index, so cc @nodejs/tsc

mcollina
mcollina approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joyeecheung joyeecheung added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 6, 2024
mhdawson
mhdawson approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 7, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/53343
✔  Done loading data for nodejs/node/pull/53343
----------------------------------- PR info ------------------------------------
Title      doc: mark --cpu-prof and --heap-prof as stable (#53343)
Author     Joyee Cheung  (@joyeecheung)
Branch     joyeecheung:prof-stable -> nodejs:main
Labels     doc, cli, author ready
Commits    2
 - doc: mark --cpu-prof and related flags stable
 - doc: mark --heap-prof and related flags stable
Committers 1
 - Joyee Cheung 
PR-URL: https://github.com/nodejs/node/pull/53343
Reviewed-By: Matteo Collina 
Reviewed-By: Richard Lau 
Reviewed-By: Paolo Insogna 
Reviewed-By: Ruy Adorno 
Reviewed-By: Marco Ippolito 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Trivikram Kamat 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53343
Reviewed-By: Matteo Collina 
Reviewed-By: Richard Lau 
Reviewed-By: Paolo Insogna 
Reviewed-By: Ruy Adorno 
Reviewed-By: Marco Ippolito 
Reviewed-By: Chengzhong Wu 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Trivikram Kamat 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 05 Jun 2024 10:21:32 GMT
   ✔  Approvals: 9
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2098775174
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2098794896
   ✔  - Paolo Insogna (@ShogunPanda) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2098801130
   ✔  - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2099519437
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2099556656
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2101341580
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53343#pullrequestreview-2103112398
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/53343#pullrequestreview-2103234911
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/53343#pullrequestreview-2103692231
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   479b8e5232..a2233c39c8  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - ab971dc739 src: use v8::(Des|S)erializeInternalFieldsCallback
 - a2233c39c8 src: use v8::(Des|S)erializeInternalFieldsCallback
--------------------------------------------------------------------------------
HEAD is now at a2233c39c8 src: use v8::(Des|S)erializeInternalFieldsCallback
   ✔  Reset to origin/main
- Downloading patch for 53343
From https://github.com/nodejs/node
 * branch                  refs/pull/53343/merge -> FETCH_HEAD
✔  Fetched commits as a2233c39c830..4dda1e792a8a
--------------------------------------------------------------------------------
Auto-merging doc/api/cli.md
[main d088d84b6d] doc: mark --cpu-prof and related flags stable
 Author: Joyee Cheung 
 Date: Wed Jun 5 12:16:00 2024 +0200
 1 file changed, 24 insertions(+), 4 deletions(-)
Auto-merging doc/api/cli.md
[main 80e66b769c] doc: mark --heap-prof and related flags stable
 Author: Joyee Cheung 
 Date: Wed Jun 5 12:17:10 2024 +0200
 1 file changed, 24 insertions(+), 4 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

doc: mark --cpu-prof and related flags stable


PR-URL: #53343

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: Richard Lau rlau@redhat.com

Reviewed-By: Paolo Insogna paolo@cowtech.it

Reviewed-By: Ruy Adorno ruy@vlt.sh

Reviewed-By: Marco Ippolito marcoippolito54@gmail.com

Reviewed-By: Chengzhong Wu legendecas@gmail.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Michael Dawson midawson@redhat.com

Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com


[detached HEAD cca8f48939] doc: mark --cpu-prof and related flags stable

Author: Joyee Cheung joyeec9h3@gmail.com

Date: Wed Jun 5 12:16:00 2024 +0200

1 file changed, 24 insertions(+), 4 deletions(-)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

doc: mark --heap-prof and related flags stable


PR-URL: #53343

Reviewed-By: Matteo Collina matteo.collina@gmail.com

Reviewed-By: Richard Lau rlau@redhat.com

Reviewed-By: Paolo Insogna paolo@cowtech.it

Reviewed-By: Ruy Adorno ruy@vlt.sh

Reviewed-By: Marco Ippolito marcoippolito54@gmail.com

Reviewed-By: Chengzhong Wu legendecas@gmail.com

Reviewed-By: Luigi Pinca luigipinca@gmail.com

Reviewed-By: Michael Dawson midawson@redhat.com

Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com


[detached HEAD 8666c6ff97] doc: mark --heap-prof and related flags stable

Author: Joyee Cheung joyeec9h3@gmail.com

Date: Wed Jun 5 12:17:10 2024 +0200

1 file changed, 24 insertions(+), 4 deletions(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/9416349123

@joyeecheung joyeecheung added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2024
nodejs-github-bot pushed a commit that referenced this pull request Jun 7, 2024
@joyeecheung @nodejs-github-bot
doc: mark --cpu-prof and related flags stable
206027b 
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Jun 7, 2024
@joyeecheung @nodejs-github-bot
doc: mark --heap-prof and related flags stable
673511f 
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@nodejs-github-bot
Copy link
Collaborator

Landed in 1945072...673511f

targos pushed a commit that referenced this pull request Jun 20, 2024
@joyeecheung @targos
doc: mark --cpu-prof and related flags stable
0160745 
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Jun 20, 2024
@joyeecheung @targos
doc: mark --heap-prof and related flags stable
cf375e7 
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@joyeecheung @sophoniie
doc: mark --cpu-prof and related flags stable
03debad 
PR-URL: nodejs#53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
sophoniie pushed a commit to sophoniie/node that referenced this pull request Jun 20, 2024
@joyeecheung @sophoniie
doc: mark --heap-prof and related flags stable
9ff4255 
PR-URL: nodejs#53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@joyeecheung @bmeck
doc: mark --cpu-prof and related flags stable
aa40bc4 
PR-URL: nodejs#53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@joyeecheung @bmeck
doc: mark --heap-prof and related flags stable
519746a 
PR-URL: nodejs#53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos added a commit that referenced this pull request Jun 25, 2024
@targos
2024-06-26, Version 22.4.0 (Current)
8efb279 
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
@targos targos mentioned this pull request Jun 25, 2024
Merged
targos added a commit that referenced this pull request Jun 26, 2024
@targos
2024-06-26, Version 22.4.0 (Current)
e7e7e93 
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
targos added a commit that referenced this pull request Jul 1, 2024
@targos
2024-07-02, Version 22.4.0 (Current)
7e13cc5 
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
targos added a commit that referenced this pull request Jul 2, 2024
@targos
2024-07-02, Version 22.4.0 (Current)
056f055 
Notable changes:

deps,lib,src:
  * (SEMVER-MINOR) add experimental web storage (Colin Ihrig) #52435
doc:
  * move `node --run` stability to rc (Yagiz Nizipli) #53433
  * mark WebSocket as stable (Matthew Aitken) #53352
  * mark --heap-prof and related flags stable (Joyee Cheung) #53343
  * mark --cpu-prof and related flags stable (Joyee Cheung) #53343
  * doc-only deprecate OpenSSL engine-based APIs (Richard Lau) #53329
inspector:
  * fix disable async hooks on Debugger.setAsyncCallStackDepth (Joyee Cheung) #53473
lib:
  * (SEMVER-MINOR) add diagnostics_channel events to module loading (RafaelGSS) #44340
util:
  * (SEMVER-MINOR) support `--no-` for argument with boolean type for parseArgs (Zhenwei Jin) #53107

PR-URL: #53583
@Karliz24 Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@joyeecheung @marco-ippolito
doc: mark --cpu-prof and related flags stable
c431010 
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@joyeecheung @marco-ippolito
doc: mark --heap-prof and related flags stable
8472ff8 
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@joyeecheung @marco-ippolito
doc: mark --cpu-prof and related flags stable
0b9daaa 
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@joyeecheung @marco-ippolito
doc: mark --heap-prof and related flags stable
a3e8cda 
PR-URL: #53343
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@trivikr trivikr trivikr approved these changes

@mhdawson mhdawson mhdawson approved these changes

@legendecas legendecas legendecas approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.