stream: callback should be called when pendingcb is 0 #53438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
jakecastelli
changed the title
mcollina
reviewed
Jun 13, 2024
| @@ -679,5 +679,6 @@ testClosed((opts) => new Writable({ write() {}, ...opts })); | |||
|
|
|||
| finished(stream, { readable: false }, common.mustCall((err) => { | |||
| assert(!err); | |||
| assert.strictEqual(stream._writableState.pendingcb, 0); | |||
There was a problem hiding this comment.
Can you add a test that does not look into _writableState? Why are you doing this change?
There was a problem hiding this comment.
sure, I will add a new test to address it, thanks!
Why are you doing this change?
Do you mean the change to the test? If so, it is because when the callback function is called in stream.finished it won't wait for the callback in the writable._write (if any async action is performed) and one of the indication is stream._writableState.pendingcb is not 0.
There was a problem hiding this comment.
I have expanded the test to make sure the cb in _write is called before the cb in finished is called. PTAL @mcollina 🙏
Make sure the callback in `write` is called before the callback in finished
ronag
reviewed
Jun 13, 2024
Co-authored-by: Robert Nagy <ronagy@icloud.com>
ronag
approved these changes
Jun 13, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
atlowChemi
approved these changes
Jun 13, 2024
atlowChemi
added
author ready
jasnell
approved these changes
Jun 14, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 177d63f |
sophoniie
pushed a commit
to sophoniie/node
that referenced
this pull request
Jun 20, 2024
Fixes: nodejs#46170 PR-URL: nodejs#53438 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Fixes: nodejs#46170 PR-URL: nodejs#53438 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback should be called when the
pendingcbis 0.Time spent on this issue: 12 hours+, I would appreciate any comment or feedback on this 🙏
Fixes: #46170