Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: fix delete test file cause dependency file change not rerun the tests #53533

Merged
merged 5 commits into from
Aug 14, 2024
Merged

test_runner: fix delete test file cause dependency file change not rerun the tests #53533

merged 5 commits into from
Aug 14, 2024
+110 −1

Commits on Aug 7, 2024

  1. test_runner: fix delete test file cause dependency file not watched 

    When a watched test file is being deleted then the referenced dependency
file(s) will be updated incorrect when `unfilterFilesOwnedBy` method is
called, which will cause tests not being rerun when its referenced
dependency changed. To prevent this case, we can simply `return` when we
detect a watched test file being deleted.
    @jakecastelli
    jakecastelli committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3c0dcb2 View commit details
    Browse the repository at this point in the history

  2. Update test/parallel/test-runner-watch-mode-complex.mjs 

    Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
    @jakecastelli @atlowChemi
    jakecastelli and atlowChemi committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ad6e0cd View commit details
    Browse the repository at this point in the history

  3. fixup

    @jakecastelli
    jakecastelli committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    fa2d227 View commit details
    Browse the repository at this point in the history

  4. fixup! lint

    @jakecastelli
    jakecastelli committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    d8c53f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. fixup! skip AIX as watch is limited

    @jakecastelli
    jakecastelli committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b1e06fc View commit details
    Browse the repository at this point in the history