Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use correct file naming syntax for util-parse-env #53705

Merged
merged 1 commit into from
Sep 13, 2024
Merged

test: use correct file naming syntax for util-parse-env #53705

merged 1 commit into from
Sep 13, 2024

Conversation

RedYetiDev
Copy link
Member

The project's test runner will only run files beginning with test-, so this PR fixes util-parse-env.js to test-util-parse-env.js.

@RedYetiDev RedYetiDev added util Issues and PRs related to the built-in util module. test Issues and PRs related to the tests. dotenv Issues and PRs related to .env file parsing labels Jul 2, 2024
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 3, 2024
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RedYetiDev
Copy link
Member Author

Is this good to land?

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 6, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RedYetiDev
Copy link
Member Author

Tests are failing :-/, CC @IlyasShabi

@RedYetiDev
Copy link
Member Author

The issue was that the fixture was updated in a different PR, leading this file to remain unupdated. It is now updated.

@RedYetiDev

This comment was marked as outdated.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Aug 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.91%. Comparing base (e1e312d) to head (8589582).
Report is 49 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #53705      +/-   ##
==========================================
+ Coverage   87.90%   87.91%   +0.01%     
==========================================
  Files         651      651              
  Lines      183343   183343              
  Branches    35710    35712       +2     
==========================================
+ Hits       161165   161187      +22     
+ Misses      15466    15433      -33     
- Partials     6712     6723      +11

see 39 files with indirect coverage changes

@RedYetiDev
Copy link
Member Author

(rebased main into the PR)

@RedYetiDev RedYetiDev added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/10444728825

@github-actions github-actions bot added the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Aug 18, 2024
@RedYetiDev RedYetiDev removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Aug 18, 2024
@RedYetiDev
Copy link
Member Author

😅 I always forget which different little peices cause the CI to fail to start...

@RedYetiDev
Copy link
Member Author

This should be good now that I've fixed the tests to account for the newer changes, could someone start a new CI to verify that?

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RedYetiDev
Copy link
Member Author

RedYetiDev commented Aug 26, 2024 •
edited
Loading

CI is passing + many approving reviews, author ready for this to land?

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@anonrig
Copy link
Member

anonrig commented Sep 8, 2024

There are 3 failing checks. Can you rebase and force push? We can't land a pull-request when existing CI is failing.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RedYetiDev
Copy link
Member Author

Rebased.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 8, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62195/

@jasnell jasnell removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 9, 2024
@RedYetiDev
Copy link
Member Author

FWIW CI failures are flakes

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62406/

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 13, 2024
@nodejs-github-bot nodejs-github-bot merged commit b4088f5 into nodejs:main Sep 13, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b4088f5

RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@RedYetiDev @RafaelGSS
test: use correct file naming syntax for util-parse-env
4a49add 
PR-URL: #53705
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
@RedYetiDev @RafaelGSS
test: use correct file naming syntax for util-parse-env
d7afb1c 
PR-URL: #53705
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
@RedYetiDev @RafaelGSS
test: use correct file naming syntax for util-parse-env
d9264bc 
PR-URL: #53705
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
dotenv Issues and PRs related to .env file parsing needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RedYetiDev @nodejs-github-bot @anonrig @jasnell @lpinca @targos @richardlau @atlowChemi