-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: put description of PR to the end of tmpl #5378
github: put description of PR to the end of tmpl #5378
Conversation
It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template.
cc @nodejs/collaborators @Fishrock123 @mscdex and all others. |
Now that I can see it rendered, can this line be moved to the end of the previous line? |
@mscdex it will go over 80 columns, perhaps I should move |
@mscdex hopefully, ack |
LGTM. Perhaps in a separate PR I'd like to not that checklist items that do not apply can be removed. (i.e. doc changes, example: #5391) |
Landed in 4bd8b20, thank you! Please feel free to open follow-up PR. |
It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template. PR-URL: #5378 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template. PR-URL: #5378 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test
(UNIX) orvcbuild test nosign
(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done afterwards /
while the PR is open.
Affected core subsystem(s)
Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)
Description of change
It looks like github appends commit log right after the template
contents. Seeing this it does not look logical to ask for details first.
This commit puts
Description of change
part to the end of thetemplate.
NOTE: I had to manually re-order this to put Description of change to the bottom in this PR