Revert "fs: add v8 fast api to closeSync"

[avivkeller]

This reverts commit ed6f45b (#53627). That commit appears to have introduced regressions into 22.5.0, so this PR reverts it.

Fixes #53902
Ref: yarnpkg/berry#6398
Ref: npm/cli#7657
(And all linked issues in the ones above)

CC @anonrig

[anonrig]

Let's wait for landing this PR for a couple days in case we can find a solution that doesn't require a revert, unless we ship a new version soon.

[avivkeller]

Re-opening per #53902 (comment)

[avivkeller]

Let's wait for landing this PR for a couple days in case we can find a solution that doesn't require a revert, unless we ship a new version soon.

@anonrig (I know it's only been a few hours) The other PR (according to #53902 (comment)) only resolves part of the issue, and reverting it will resolve the other part. IMO the revert should be sent out in a patch for 22.5.X, so that users have a stable 22.5?

[anonrig]

@anonrig (I know it's only been a few hours) The other PR (according to #53902 (comment)) only resolves part of the issue, and reverting it will resolve the other part. IMO the revert should be sent out in a patch for 22.5.X, so that users have a stable 22.5?

What other issue are you referring to? #53910 fixes the crash.

[avivkeller]

According to #53902 (comment), Yarn scripts fail with:

Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)

I've confirmed this is the case with 22.5.0, but I haven't tested your patch.

[avivkeller]

I'm cloning your PR now, so I'll test whether or not it fixes the yarn issue

[merceyz]

According to #53902 (comment), Yarn scripts fail with:

Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)

I've confirmed this is the case with 22.5.0, but I haven't tested your patch.

Quoting myself from #53902 (comment):

Note that the issue happens in the yarn step where the process exits early without an error, yarn build fails because yarn failed.

So that issue isn't reproduced by yarn build but in yarn.

[avivkeller]

Does @anonrig's PR fix the issue?

[avivkeller]

After testing:

• Current (v22.5.0): yarn install -> Hangs on 'Link Step'
• @anonrig's PR: yarn install -> Hangs on 'Link Step'
• My PR: yarn install -> Success

[anonrig]

After testing:

• Current (v22.5.0): yarn install -> Hangs on 'Link Step'
• @anonrig's PR: yarn install -> Hangs on 'Link Step'
• My PR: yarn install -> Success

@RedYetiDev Reverting this PR will fix this problem but postpone the timeline to find the root cause of the underlying problem. Since V8 fast APIs are added constantly, and will be added in the future, it is important to gather as much as evidence as we can in order to increase our test suite to prevent regressions. Since, we have time, we should merge this PR as a last resort in case we can't find a solution before we create a new Node.js release. Right now, we have time, and without finding the root cause, merging this PR will not help the project.

I understand your eagerness but we need to learn from our bugs/mistakes and missing test coverage so that we don't break Yarn in the future specific to this.

As of now, I recommend gathering as much as data we can, to find a suitable regression, that doesn't force us to run an external script.

[avivkeller]

Right now, we have time, and without finding the root cause, merging this PR will not help the project.

Got it. Thanks, I exaggerated, and you are right. We do have time to find the cause. I'll look into it more rather than to just revert.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60422/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3460/

[richardlau]

I think we want to get a fixed Node.js 22 release out for #53902 sooner rather than later.

If #53910 is ready (looks like it might have related CI failures) then I'll have no objections to landing that instead of this revert.

[merceyz]

Does @anonrig's PR fix the issue?

Not the issue affecting Yarn, no.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60425/

[avivkeller]

I think we want to get a fixed Node.js 22 release out for #53902 sooner rather than later.

Given the widespread issues, I agree.

---

CI has passed for this PR.

[anonrig]

cc @nodejs/releasers can we release a new version with this commit?

[github-actions]

Fast-track has been requested by @anonrig. Please 👍 to approve.

[nodejs-github-bot]

Landed in c0c7e86

[avivkeller]

cc @nodejs/releasers can we release a new version with this commit?

Agreed. as discussed here, other issues, and slack, I believe the best course of action is to release a patch, and urge users to update.