Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(vee-eight-4.9) contextify: update deprecated SetWeak usage #5392

Closed
wants to merge 4 commits into from
Closed

(vee-eight-4.9) contextify: update deprecated SetWeak usage #5392

wants to merge 4 commits into from

Commits on Feb 25, 2016

  1. contextify: cleanup weak ref for global proxy 

    Cleanup how node_contextify keeps weak references in order to prepare
for new style phantom weakness API. We didn't need to keep a weak
reference to the context's global proxy, as the context holds it.
    @ofrobots
    ofrobots committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    820a1aa View commit details
    Browse the repository at this point in the history

  2. contextify: cleanup weak ref for sandbox 

    Simplify how node_contextify was keeping a weak reference to the
sandbox object in order to prepare for new style phantom weakness V8
API. It is simpler (and more robust) for the context to hold a
reference to the sandbox in an embedder data field. Doing otherwise
meant that the sandbox could become weak while the context was still
alive. This wasn't a problem because we would make the reference
strong at that point.

Since the sandbox must live at least as long as the context, it
would be better for the context to hold onto the sandbox.
    @ofrobots
    ofrobots committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    6edaab5 View commit details
    Browse the repository at this point in the history

  3. contextify: replace deprecated SetWeak usage

    @ofrobots
    ofrobots committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    9f2d84a View commit details
    Browse the repository at this point in the history

  4. contextify: cache sandbox and context in locals

    @ofrobots
    ofrobots committed Feb 25, 2016
    Configuration menu
    Copy the full SHA
    fd21188 View commit details
    Browse the repository at this point in the history