Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: do not warn for typeless package.json when there isn't one #54045

Merged
merged 1 commit into from
Jul 29, 2024

Commits on Jul 25, 2024

  1. module: do not warn for typeless package.json when there isn't one

    It was intended that warnings should only be emitted for an
    existing package.json without a type. This fixes a confusing
    warning telling users to update /package.json when there are
    no package.json on the lookup path at all, like this:
    
    [MODULE_TYPELESS_PACKAGE_JSON] Warning: ... parsed as an ES module
    because module syntax was detected; to avoid the performance penalty
    of syntax detection, add "type": "module" to /package.json
    
    Drive-by: update the warning message to be clear about
    reparsing and make it clear what's actionable.
    joyeecheung committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    cf52a8b View commit details
    Browse the repository at this point in the history