Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix extensionless typescript in cjs loader #54062

Merged
merged 1 commit into from
Jul 29, 2024
Merged

module: fix extensionless typescript in cjs loader #54062

merged 1 commit into from
Jul 29, 2024

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Jul 26, 2024 •
edited
Loading

Annoying bug that allowed extensionless typescript imports to work in cjs loader.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 26, 2024
@marco-ippolito marco-ippolito force-pushed the feat/fix-annoying-cjs-bug branch 2 times, most recently from 5bbe964 to 75f97ce Compare July 27, 2024 05:28
@ChALkeR ChALkeR mentioned this pull request Jul 27, 2024
Merged
ChALkeR
ChALkeR approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the change above for .cts

@ChALkeR
Copy link
Member

ChALkeR commented Jul 27, 2024

Also, a test perhaps is missing for the .cts case

@marco-ippolito
Copy link
Member Author

marco-ippolito commented Jul 27, 2024 •
edited
Loading

Ill add a test for cts later today

@ChALkeR
Copy link
Member

ChALkeR commented Jul 28, 2024 •
edited
Loading

Nice
This looks ready

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60689/

@atlowChemi atlowChemi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 28, 2024
mcollina
mcollina approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60714/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60725/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60728/

@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit cf9a814 into nodejs:main Jul 29, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in cf9a814

targos pushed a commit that referenced this pull request Jul 30, 2024
@marco-ippolito @targos
module: fix extensionless typescript in cjs loader
11aef40 
PR-URL: #54062
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 5, 2024
@marco-ippolito @RafaelGSS
module: fix extensionless typescript in cjs loader
ab1f0b4 
PR-URL: #54062
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@marco-ippolito @nodejs-github-bot @ChALkeR @mcollina @jasnell @benjamingr @anonrig @atlowChemi @targos