Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated test descriptions #54140

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fix duplicated test descriptions #54140

merged 2 commits into from
Sep 27, 2024

Conversation

unseen1980
Copy link
Contributor

Some unit tests had duplicate names. Please review these small changes.

Thanks
Christos

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (b4fd1fd) to head (b55ca4c).
Report is 580 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54140      +/-   ##
==========================================
+ Coverage   87.06%   87.61%   +0.54%     
==========================================
  Files         643      650       +7     
  Lines      181576   182834    +1258     
  Branches    34894    35383     +489     
==========================================
+ Hits       158088   160183    +2095     
+ Misses      16759    15924     -835     
+ Partials     6729     6727       -2

see 183 files with indirect coverage changes

mhdawson
mhdawson approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avivkeller avivkeller added test Issues and PRs related to the tests. strip-types Issues or PRs related to strip-types support labels Aug 10, 2024
@avivkeller
Copy link
Member

avivkeller commented Aug 10, 2024 •
edited
Loading

Hey @unseen1980. Just want to let you know the first commit is authored by @ckoutsiaris (just making sure this is intentional). Additionally, could you remove the trailing .? Punctuation isn't supposed to be in commit messages.

Thank you!

@unseen1980 unseen1980 force-pushed the duplicated-test-names branch from 89b21c0 to 70ce115 Compare August 11, 2024 20:26
@unseen1980 unseen1980 changed the title Fix duplicated test descriptions. Fix duplicated test descriptions Aug 11, 2024
@unseen1980
Copy link
Contributor Author

Hey @unseen1980. Just want to let you know the first commit is authored by @ckoutsiaris (just making sure this is intentional). Additionally, could you remove the trailing .? Punctuation isn't supposed to be in commit messages.

Thank you!

Hi @RedYetiDev yes that is fine, same person :) I removed the . and I reset the commit history, please review again. Thank you 👍

@avivkeller
Copy link
Member

Sorry I forgot to mention this earlier, but in order to land, the commit needs to be prefixed with a subsystem, followed by an active verb.

For example, test: remove ...

mcollina
mcollina approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61043/

@unseen1980 unseen1980 force-pushed the duplicated-test-names branch from 70ce115 to 1c293cb Compare August 12, 2024 11:04
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2024
mcollina
mcollina approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 14, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61108/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61276/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61280/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61286/

@aduh95 aduh95 force-pushed the duplicated-test-names branch from 1c293cb to 4e93a87 Compare August 20, 2024 16:49
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61291/

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62260/

@avivkeller avivkeller removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 10, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62531/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62540/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62544/

@unseen1980
Copy link
Contributor Author

Hello, is there anything I need to do from my side?

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62729/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62730/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62748/

@aduh95
Copy link
Contributor

aduh95 commented Sep 25, 2024

CONFLICT (content): Merge conflict in test/es-module/test-typescript-module.mjs. Let me rebase to fix that.

@aduh95 aduh95 force-pushed the duplicated-test-names branch from b55ca4c to 66300fe Compare September 25, 2024 15:01
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62763/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit fbc6fcb into nodejs:main Sep 27, 2024
55 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fbc6fcb

@unseen1980
Copy link
Contributor Author

Thank you all 👍

targos pushed a commit that referenced this pull request Oct 4, 2024
@unseen1980 @targos
test: remove duplicated test descriptions
2df6e94 
PR-URL: #54140
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Oct 4, 2024
@unseen1980 @targos
test: remove duplicated test descriptions
0999b5e 
PR-URL: #54140
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@unseen1980 @louwers
test: remove duplicated test descriptions
403a3d8 
PR-URL: nodejs#54140
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Nov 16, 2024
tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
@unseen1980 @tpoisseau
test: remove duplicated test descriptions
53b5839 
PR-URL: nodejs#54140
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecastelli jakecastelli jakecastelli approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@unseen1980 @nodejs-github-bot @avivkeller @marco-ippolito @aduh95 @mcollina @jasnell @lpinca @mhdawson @jakecastelli