module: do not attempt to strip type when there's no source #54287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
marco-ippolito
approved these changes
Aug 9, 2024
VoltrexKeyva
approved these changes
Aug 9, 2024
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Aug 9, 2024
aduh95
added
the
author ready
MoLow
approved these changes
Aug 10, 2024
anonrig
approved these changes
Aug 10, 2024
jasnell
approved these changes
Aug 11, 2024
|
if #54250 lands we want to rethink this approach |
aduh95
added
the
commit-queue
I don't see why, it's still a win to avoid calling |
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9a4eb21 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54287 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54287 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It bothers me that
tsParsewould return an empty string on non-string input, IMO it makes much more sense to use an assertion instead, and make sure the other parts of the code calling that function have already validated the input.