src: update compile cache storage structure #54291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54291 +/- ##
==========================================
- Coverage 87.11% 87.08% -0.03%
==========================================
Files 647 647
Lines 181773 181965 +192
Branches 34889 34909 +20
==========================================
+ Hits 158347 158470 +123
- Misses 16739 16777 +38
- Partials 6687 6718 +31
|
|
cc @nodejs/startup @nodejs/cpp-reviewers |
addaleax
approved these changes
Aug 10, 2024
anonrig
reviewed
Aug 11, 2024
jasnell
approved these changes
Aug 11, 2024
This refactors the compile cache handler in preparation for the
JS API, and updates the compile cache storage structure into:
- $NODE_COMPILE_CACHE_DIR
- $NODE_VERION-$ARCH-$CACHE_DATA_VERSION_TAG-$UID
- $FILENAME_AND_MODULE_TYPE_HASH.cache
This also adds a magic number to the beginning of the cache
files for verification, and returns the status, compile
cache directory and/or error message of enabling the
compile cache in a structure, which can be converted as
JS counterparts by the upcoming JS API.
joyeecheung
force-pushed
the
refactor-compile-cache
branch
from
afb5bbc to
8f9eb07
Compare
FYI most of the changes here are preparation for https://github.com/joyeecheung/node/tree/compile-cache-api so I only sketched out what the changes are for in the commit messages, not in the comments. |
Ethan-Arrowood
approved these changes
Aug 12, 2024
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
legendecas
approved these changes
Aug 15, 2024
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in b246f22 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
This refactors the compile cache handler in preparation for the
JS API, and updates the compile cache storage structure into:
- $NODE_COMPILE_CACHE_DIR
- $NODE_VERION-$ARCH-$CACHE_DATA_VERSION_TAG-$UID
- $FILENAME_AND_MODULE_TYPE_HASH.cache
This also adds a magic number to the beginning of the cache
files for verification, and returns the status, compile
cache directory and/or error message of enabling the
compile cache in a structure, which can be converted as
JS counterparts by the upcoming JS API.
PR-URL: #54291
Refs: #53639
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 21, 2024
This refactors the compile cache handler in preparation for the
JS API, and updates the compile cache storage structure into:
- $NODE_COMPILE_CACHE_DIR
- $NODE_VERION-$ARCH-$CACHE_DATA_VERSION_TAG-$UID
- $FILENAME_AND_MODULE_TYPE_HASH.cache
This also adds a magic number to the beginning of the cache
files for verification, and returns the status, compile
cache directory and/or error message of enabling the
compile cache in a structure, which can be converted as
JS counterparts by the upcoming JS API.
PR-URL: #54291
Refs: #53639
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the compile cache handler in preparation for the JS API, and updates the compile cache storage structure into:
This also adds a magic number to the beginning of the cache
files for verification, and returns the status, compile
cache directory and/or error message of enabling the
compile cache in a structure, which can be converted as
JS counterparts by the upcoming JS API.
Refs: #53639