src,test: track URL.canParse fast API calls
#54356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also regroup two small test files for naming consistency and simplify the tests.
|
Review requested:
|
nodejs-github-bot
added
c++
lemire
approved these changes
Aug 13, 2024
anonrig
approved these changes
Aug 13, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54356 +/- ##
==========================================
- Coverage 87.09% 87.09% -0.01%
==========================================
Files 648 648
Lines 182213 182213
Branches 34961 34958 -3
==========================================
- Hits 158703 158700 -3
- Misses 16794 16798 +4
+ Partials 6716 6715 -1
|
benjamingr
approved these changes
Aug 13, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Aug 14, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0549590 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
Also regroup two small test files for naming consistency and simplify the tests. PR-URL: #54356 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 21, 2024
Also regroup two small test files for naming consistency and simplify the tests. PR-URL: #54356 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also regroup two small test files for naming consistency and simplify
the tests.