Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update required python version to 3.8 #54358

Merged
merged 5 commits into from
Aug 23, 2024
Merged

build: update required python version to 3.8 #54358

merged 5 commits into from
Aug 23, 2024

Conversation

avivkeller
Copy link
Member

Closes #54112

Configure scripts use := operator now, which requires python 3.8.

File "tools/gyp/pylib/gyp/common.py", line 435 if CC := os.environ.get("CC_target") or os.environ.get("CC"):

@avivkeller @d3x0r
build: update required python version to 3.8
ec66d4c 
Co-Authored-By: Jim B <d3x0r@users.noreply.github.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. labels Aug 13, 2024
@avivkeller avivkeller added the python PRs and issues that require attention from people who are familiar with Python. label Aug 13, 2024
@avivkeller avivkeller added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 13, 2024
@richardlau richardlau added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Aug 13, 2024
@avivkeller
Copy link
Member Author

avivkeller commented Aug 13, 2024 •
edited
Loading

CC @nodejs/python @nodejs/build

CC previous participants @d3x0r @lpinca

@cclauss
Copy link
Contributor

cclauss commented Aug 13, 2024

Instead of doing this over and over again, I would strongly recommend that we point readers to the currently supported versions as we do at https://github.com/nodejs/node-gyp/blob/main/README.md#on-unix

cclauss
cclauss requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were my comments unclear?

@avivkeller
Copy link
Member Author

Instead of doing this over and over again, I would strongly recommend that we point readers to the currently supported versions as we do at nodejs/node-gyp@main/README.md#on-unix

I've made that change to the "Windows" section, but I think it's okay to keep the exact version in "Prerequisites". As for 3.12, I think that's an issue for a different PR, as this one is specifically removing up until 3.8, not adding more versions.

@avivkeller avivkeller requested a review from cclauss August 13, 2024 20:10
@avivkeller
Copy link
Member Author

avivkeller commented Aug 13, 2024 •
edited
Loading

@cclauss I noticed you 👎 my comment, is there a specific part you'd like to be changed?

It's also worth noting the 'missing' v3.12 is specificly for the android compilation.

@avivkeller avivkeller mentioned this pull request Aug 13, 2024
Closed
@anonrig
Copy link
Member

anonrig commented Aug 14, 2024

Did I stutter?

@cclauss What's the basis of blocking this pull request? I didn't understand.

@jasnell
Copy link
Member

jasnell commented Aug 14, 2024

@cclauss ... The "did I stutter" comment here is unproductive, unfriendly, and unhelpful. If you are requesting changes to this PR please articulate what those are.

@cclauss
Copy link
Contributor

cclauss commented Aug 14, 2024 •
edited
Loading

If you are requesting changes to this PR please articulate what those are.

My requested changes have already been stated. If you choose to ignore them then please proceed. My contributions to Node.js have been all about keeping its Python infrastructure current. My suggestions above are merely a continuation of that effort to ensure that Node.js users open fewer Python-related issues.

@jasnell
Copy link
Member

jasnell commented Aug 14, 2024

I understand that you have requested changes. The issue is more the rather disrespectful way you presented your change request. The "did I stutter" comment was disrespectful.

Trott
Trott approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without changing android-configure to support 3.12 (and 3.13, just to be synchronized with configure) but I do have a slight preference that it be changed in this PR.

cclauss
cclauss approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I or someone else will revisit these files to complete the task.

Ignoring my review comments, marking them resolved, and leaving the work for others to do is disrespectful thus my snarkiness.

BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated Show resolved Hide resolved
android-configure Show resolved Hide resolved
android-configure Show resolved Hide resolved
avivkeller and others added 2 commits August 14, 2024 07:13
@avivkeller @cclauss
Update BUILDING.md
3ff39a3 
Co-authored-by: Christian Clauss <cclauss@me.com>
@avivkeller @cclauss
Update BUILDING.md
e7f8549 
Co-authored-by: Christian Clauss <cclauss@me.com>
@avivkeller
Copy link
Member Author

avivkeller commented Aug 14, 2024 •
edited
Loading

Ignoring my review comments, marking them resolved, and leaving the work for others to do is disrespectful thus my snarkiness.

I'm sorry if you feel my response was disrespectful. I had no intention of it coming off that way.

Ignoring my review comments

I don't want you to think I'm ignoring your review comments. Your insight is extremely important.

marking them resolved

I only marked one of your reviews as resolved, as I felt it would be easier to manage if there was one conversation rather than two going on about the same topic.

and leaving the work for others to do

I'm happy to do the work required for android's configure script to support 3.12 and 3.13, I just don't believe that work should be done in this PR.

@cclauss
Copy link
Contributor

cclauss commented Aug 14, 2024

I think we are all good @RedYetiDev. I do appreciate your work and I apologize for being snarky.

I approved this PR so we can move forward...

@Trott Trott added commit-queue Add this label to land a pull request using GitHub Actions. doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python. needs-ci PRs that need a full CI run. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Aug 23, 2024
@cclauss
Copy link
Contributor

cclauss commented Aug 23, 2024

@redyetidev the red message below says Merging is blocked.

@Trott
Copy link
Member

Trott commented Aug 23, 2024

@RedYetiDev the red message below says Merging is blocked.

I think that's what it says on all of our PRs. I think of it as a way to mostly make sure no one accidentally uses the GitHub button.

@Trott
Copy link
Member

Trott commented Aug 23, 2024

@Trott did you mean to remove all the other labels?

Nope. That's why I immediately re-added them. Not sure how they all got de-selected. I might need my web-browsing license revoked.

@avivkeller
Copy link
Member Author

Nope. That's why I immediately re-added them. Not sure how they all got de-selected. I might need my web-browsing license revoked.

Happens to me more often that i can count... 😆

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2024
@nodejs-github-bot nodejs-github-bot merged commit 22daeba into nodejs:main Aug 23, 2024
77 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 22daeba

@avivkeller avivkeller mentioned this pull request Aug 23, 2024
Closed
@avivkeller
Copy link
Member Author

android-configure Python 3.13 support in a follow-up at #54529

RafaelGSS pushed a commit that referenced this pull request Aug 25, 2024
@avivkeller @d3x0r @RafaelGSS
build: update required python version to 3.8
89af95c 
Co-Authored-By: Jim B <d3x0r@users.noreply.github.com>
PR-URL: #54358
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 25, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@avivkeller @d3x0r @RafaelGSS
build: update required python version to 3.8
71fdf96 
Co-Authored-By: Jim B <d3x0r@users.noreply.github.com>
PR-URL: #54358
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@avivkeller avivkeller mentioned this pull request Oct 2, 2024
Merged
@avivkeller avivkeller added backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. and removed dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Oct 2, 2024
@avivkeller
Copy link
Member Author

Hey, I'm requesting this be back ported to v20 per the discussion in the v20.18.0 release proposal, feel free to adjust

@cclauss
Copy link
Contributor

cclauss commented Oct 2, 2024 •
edited
Loading

Python 3.8 goes EOL on Monday so let's stop supporting it.

@avivkeller
Copy link
Member Author

avivkeller commented Oct 2, 2024 •
edited
Loading

Okay. I'll update the required version to 3.12, but I think 3.8 is okay for v20

@targos
Copy link
Member

targos commented Oct 2, 2024

I'll update the required version to 3.12

Please don't. We need some common denominator with the CI machines that are on non-EOL OS.

@cclauss
Copy link
Contributor

cclauss commented Oct 2, 2024 •
edited
Loading

After next Monday acceptable versions should be py39, py310, py311, py312, py313.

With Python's new yearly (October) release approach, there should always be five supported versions of CPython.

@avivkeller avivkeller mentioned this pull request Oct 2, 2024
Open
@avivkeller
Copy link
Member Author

I've opened a PR to drop support for 3.8

(In my comment above, I said 3.12, I meant 3.9, not sure how I mixed up those two 🤔 )

@richardlau richardlau mentioned this pull request Dec 5, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig left review comments

@jasnell jasnell jasnell left review comments

@cclauss cclauss cclauss approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
backport-requested-v20.x PRs awaiting manual backport to the v20.x-staging branch. build Issues and PRs related to build files or the CI. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@avivkeller @cclauss @anonrig @jasnell @Trott @nodejs-github-bot @targos @lpinca @richardlau