-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update amaro to 0.1.6 #54374
deps: update amaro to 0.1.6 #54374
Conversation
Review requested:
|
Actually I'll do that in a followup PR |
b6cea6b
to
7599df0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54374 +/- ##
==========================================
- Coverage 87.08% 87.08% -0.01%
==========================================
Files 648 648
Lines 182217 182217
Branches 34956 34955 -1
==========================================
- Hits 158684 158681 -3
- Misses 16819 16822 +3
Partials 6714 6714 |
There is a bit of situation on the current main (tests which rely on the Fast API would fail) PR 54391 is currently being fast tracked to fix it. Therefore the current CI run (which will rebase on main) would fail consistently. |
@nodejs/build
|
Commit Queue failed- Loading data for nodejs/node/pull/54374 ✔ Done loading data for nodejs/node/pull/54374 ----------------------------------- PR info ------------------------------------ Title deps: update amaro to 0.1.6 (#54374) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-amaro -> nodejs:main Labels lib / src, needs-ci, dependencies, strip-types Commits 1 - deps: update amaro to 0.1.6 Committers 1 - Node.js GitHub Bot <github-bot@iojs.org> PR-URL: https://github.com/nodejs/node/pull/54374 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54374 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 14 Aug 2024 14:09:38 GMT ✔ Approvals: 5 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54374#pullrequestreview-2238310298 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54374#pullrequestreview-2238350052 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/54374#pullrequestreview-2239717919 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54374#pullrequestreview-2240533263 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54374#pullrequestreview-2240538191 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2024-08-19T08:05:13Z: https://ci.nodejs.org/job/node-test-pull-request/61220/ - Querying data for job/node-test-pull-request/61220/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10452057468 |
False report maybe? As I didn't see any failure in Github CI though. |
yeah looks odd |
I could manually land this if you want, just wanted to double check before I do so. Also would be helpful if the bot can mention in the comment which action was failed 😅 |
PR-URL: #54374 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
When I use the CLI to land it says:
instead of Github CI failed Just for the information. |
Landed in d8d3a6b |
PR-URL: #54374 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
PR-URL: #54374 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This is an automated update of amaro to 0.1.6.