doc: add git node security --cleanup #54381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
ruyadorno
approved these changes
Aug 16, 2024
Trott
reviewed
Aug 17, 2024
Comment on lines
+162
to
+164
| * [ ] `git node security --cleanup`. This command will: | ||
| * Close PRs and backports. | ||
| * Close HackerOne reports: |
There was a problem hiding this comment.
Optional nit that I think simplifies layout without sacrificing clarity. (But it's a nit, so disregard if you disagree!)
Suggested change
| * [ ] `git node security --cleanup`. This command will: | |
| * Close PRs and backports. | |
| * Close HackerOne reports: | |
| * [ ] `git node security --cleanup`. This command will close PRs and backports. | |
| It will also close HackerOne reports: |
There was a problem hiding this comment.
So, the document is following the approach of:
- automated command (git node security --something)
- operation 1 that is automated
- operation 2 that is automated
- manual work
So, in case of the automated command fails (as it's still experimental), users need to know which steps to follow exactly.
marco-ippolito
approved these changes
Aug 17, 2024
RafaelGSS
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9e83853 |
RafaelGSS
added a commit
that referenced
this pull request
Aug 19, 2024
PR-URL: #54381 Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Merged
RafaelGSS
added a commit
that referenced
this pull request
Aug 21, 2024
PR-URL: #54381 Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up nodejs/node-core-utils#833