src,lib: add performance.uvMetricsInfo #54413

RafaelGSS · 2024-08-16T20:16:51Z

This commit exposes a new API to the perf_hooks.performance module. This wraps uv_metrics_info into
performance.uvMetricsInfo() function.

cc: @trevnorris

This commit exposes a new API to the perf_hooks.performance module. This wraps uv_metrics_info into performance.uvMetricsInfo() function.

trevnorris

I really appreciate you doing this. Thanks very much.

doc/api/perf_hooks.md

mcollina

lgtm

doc/api/perf_hooks.md

Co-authored-by: Tobias Nießen <tniessen@tnie.de>

nodejs-github-bot · 2024-08-17T13:46:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61185/

codecov · 2024-08-17T15:02:31Z

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.31%. Comparing base (123693c) to head (0e9cf0e).
Report is 155 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_perf.cc	95.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54413      +/-   ##
==========================================
+ Coverage   87.10%   87.31%   +0.21%     
==========================================
  Files         648      649       +1     
  Lines      182215   182783     +568     
  Branches    34955    35046      +91     
==========================================
+ Hits       158712   159606     +894     
+ Misses      16789    16465     -324     
+ Partials     6714     6712       -2

Files with missing lines	Coverage Δ
lib/internal/perf/nodetiming.js	`94.64% <100.00%> (+0.26%)`	⬆️
src/node_perf.cc	`86.83% <95.00%> (+0.73%)`	⬆️

... and 117 files with indirect coverage changes

H4ad

LGTM with some non-blocking comments.

lib/internal/perf/uv_metrics.js

H4ad · 2024-08-19T01:57:46Z

src/node_perf.cc

+  Local<Object> obj = Object::New(env->isolate());
+  obj->Set(env->context(),
+           env->loop_count(),
+           Integer::NewFromUnsigned(env->isolate(), metrics.loop_count))
+      .Check();
+  obj->Set(env->context(),
+           env->events(),
+           Integer::NewFromUnsigned(env->isolate(), metrics.events))
+      .Check();
+  obj->Set(env->context(),
+           env->events_waiting(),
+           Integer::NewFromUnsigned(env->isolate(), metrics.events_waiting))
+      .Check();


Just a note for the future optimization: maybe we should use a buffer to store these values to avoid creating and returning js objects from c++.

Yeah, I have plans to return a typed array and build the object in JS land. I'll do it in a follow up PR.

test/parallel/test-performance-uvmetricsinfo.js

nodejs-github-bot · 2024-08-20T18:27:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61295/

nodejs-github-bot · 2024-08-26T21:36:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61514/

nodejs-github-bot · 2024-08-29T15:40:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61663/

trevnorris

Excellent. Thanks for doing this.

nodejs-github-bot · 2024-08-29T19:38:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/61670/

nodejs-github-bot · 2024-08-30T14:22:30Z

Landed in 9a275e1

This commit exposes a new API to the perf_hooks.performance module. This wraps uv_metrics_info into performance.uvMetricsInfo() function. PR-URL: #54413 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Notable changes: net: * (SEMVER-MINOR) exclude ipv6 loopback addresses from server.listen (Giovanni Bucci) #54264 src: * (SEMVER-MINOR) add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE (Joyee Cheung) #54501 src,lib: * (SEMVER-MINOR) add performance.uvMetricsInfo (Rafael Gonzaga) #54413 test_runner: * (SEMVER-MINOR) add support for coverage thresholds (Aviv Keller) #54429 * (SEMVER-MINOR) support running tests in process (Colin Ihrig) #53927 * (SEMVER-MINOR) defer inheriting hooks until run() (Colin Ihrig) #53927 vm: * (SEMVER-MINOR) introduce vanilla contexts via vm.constants.DONT_CONTEXTIFY (Joyee Cheung) #54394 PR-URL: #54560

This commit exposes a new API to the perf_hooks.performance module. This wraps uv_metrics_info into performance.uvMetricsInfo() function. PR-URL: nodejs#54413 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

This commit exposes a new API to the perf_hooks.performance module. This wraps uv_metrics_info into performance.uvMetricsInfo() function. PR-URL: #54413 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Notable changes: net: * (SEMVER-MINOR) exclude ipv6 loopback addresses from server.listen (Giovanni Bucci) #54264 src: * (SEMVER-MINOR) add JS APIs for compile cache and NODE_DISABLE_COMPILE_CACHE (Joyee Cheung) #54501 src,lib: * (SEMVER-MINOR) add performance.uvMetricsInfo (Rafael Gonzaga) #54413 test_runner: * (SEMVER-MINOR) add support for coverage thresholds (Aviv Keller) #54429 * (SEMVER-MINOR) support running tests in process (Colin Ihrig) #53927 * (SEMVER-MINOR) defer inheriting hooks until run() (Colin Ihrig) #53927 vm: * (SEMVER-MINOR) introduce vanilla contexts via vm.constants.DONT_CONTEXTIFY (Joyee Cheung) #54394 PR-URL: #54560

src,lib: add performance.uvMetricsInfo

95d36a3

This commit exposes a new API to the perf_hooks.performance module. This wraps uv_metrics_info into performance.uvMetricsInfo() function.

RafaelGSS added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 16, 2024

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 16, 2024

trevnorris reviewed Aug 16, 2024

View reviewed changes

doc/api/perf_hooks.md Outdated Show resolved Hide resolved

RedYetiDev reviewed Aug 16, 2024

View reviewed changes

doc/api/perf_hooks.md Outdated Show resolved Hide resolved

RedYetiDev added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Aug 16, 2024

RafaelGSS added 2 commits August 16, 2024 17:47

fixup! src,lib: add performance.uvMetricsInfo

1861bb2

fixup! add mjs doc

85dbd8f

RafaelGSS requested a review from trevnorris August 16, 2024 20:49

mcollina approved these changes Aug 16, 2024

View reviewed changes

tniessen reviewed Aug 17, 2024

View reviewed changes

doc/api/perf_hooks.md Outdated Show resolved Hide resolved

doc/api/perf_hooks.md Outdated Show resolved Hide resolved

doc/api/perf_hooks.md Outdated Show resolved Hide resolved

doc/api/perf_hooks.md Outdated Show resolved Hide resolved

fixup! apply cr suggestions

aa4dc99

Co-authored-by: Tobias Nießen <tniessen@tnie.de>

RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 17, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 17, 2024

benjamingr approved these changes Aug 17, 2024

View reviewed changes

H4ad approved these changes Aug 19, 2024

View reviewed changes

RafaelGSS requested review from H4ad and tniessen August 20, 2024 16:38

fixup! use performance.nodeTiming instead

c1385ed

RafaelGSS force-pushed the add-uv-metrics-loop branch from 6654a2b to c1385ed Compare August 20, 2024 16:38

H4ad approved these changes Aug 20, 2024

View reviewed changes

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 20, 2024

jasnell approved these changes Aug 20, 2024

View reviewed changes

RafaelGSS added 2 commits August 29, 2024 10:33

fixup! add a comment for the test guarantees

391ce64

fixup! fixup! add a comment for the test guarantees

0e9cf0e

RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 29, 2024

trevnorris approved these changes Aug 29, 2024

View reviewed changes

richardlau approved these changes Aug 30, 2024

View reviewed changes

richardlau added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 30, 2024

marco-ippolito approved these changes Aug 30, 2024

View reviewed changes

anonrig approved these changes Aug 30, 2024

View reviewed changes

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2024

nodejs-github-bot merged commit 9a275e1 into nodejs:main Aug 30, 2024
58 checks passed

RafaelGSS mentioned this pull request Aug 30, 2024

v22.8.0 proposal #54560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src,lib: add performance.uvMetricsInfo #54413

src,lib: add performance.uvMetricsInfo #54413

RafaelGSS commented Aug 16, 2024

trevnorris left a comment

mcollina left a comment

nodejs-github-bot commented Aug 17, 2024

codecov bot commented Aug 17, 2024 •

edited

Loading

H4ad left a comment

H4ad Aug 19, 2024

RafaelGSS Aug 20, 2024

nodejs-github-bot commented Aug 20, 2024

nodejs-github-bot commented Aug 26, 2024

nodejs-github-bot commented Aug 29, 2024

trevnorris left a comment

nodejs-github-bot commented Aug 29, 2024

nodejs-github-bot commented Aug 30, 2024

src,lib: add performance.uvMetricsInfo #54413

src,lib: add performance.uvMetricsInfo #54413

Conversation

RafaelGSS commented Aug 16, 2024

trevnorris left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Aug 17, 2024

codecov bot commented Aug 17, 2024 • edited Loading

Codecov Report

H4ad left a comment

Choose a reason for hiding this comment

H4ad Aug 19, 2024

Choose a reason for hiding this comment

RafaelGSS Aug 20, 2024

Choose a reason for hiding this comment

nodejs-github-bot commented Aug 20, 2024

nodejs-github-bot commented Aug 26, 2024

nodejs-github-bot commented Aug 29, 2024

trevnorris left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Aug 29, 2024

nodejs-github-bot commented Aug 30, 2024

codecov bot commented Aug 17, 2024 •

edited

Loading