Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace --allow-fs-read by --allow-fs-write in related section #54427

Conversation

M1CK431
Copy link
Contributor

@M1CK431 M1CK431 commented Aug 17, 2024

Just notice a typo in the doc probably due to a copy/paste of the --allow-fs-read section into the --allow-fs-write section then forgot to rename some things.

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Aug 17, 2024
@M1CK431
Copy link
Contributor Author

M1CK431 commented Aug 17, 2024

@RedYetiDev Here it is (I rename the branch too) 🎉

@RedYetiDev RedYetiDev added fs Issues and PRs related to the fs subsystem / file system. permission Issues and PRs related to the Permission Model labels Aug 17, 2024
@RedYetiDev
Copy link
Member

CC @nodejs/security-wg

@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 18, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit b77476d into nodejs:main Sep 6, 2024
32 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b77476d

@M1CK431 M1CK431 deleted the doc_replace--allow-fs-read_by_--allow-fs-write_in_related_section branch September 6, 2024 08:31
aduh95 pushed a commit that referenced this pull request Sep 12, 2024
PR-URL: #54427
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. permission Issues and PRs related to the Permission Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants