zlib: simplify validators #54442
Merged
zlib: simplify validators #54442
+46
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
jasnell
approved these changes
Aug 18, 2024
github-actions
bot
removed
the
request-ci
RedYetiDev
reviewed
Aug 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54442 +/- ##
==========================================
- Coverage 87.32% 87.32% -0.01%
==========================================
Files 648 648
Lines 182321 182322 +1
Branches 34973 34975 +2
==========================================
- Hits 159210 159209 -1
- Misses 16376 16392 +16
+ Partials 6735 6721 -14
|
anonrig
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54442 ✔ Done loading data for nodejs/node/pull/54442 ----------------------------------- PR info ------------------------------------ Title zlib: simplify validators (#54442) Author Yagiz Nizipli <yagiz@nizipli.com> (@anonrig) Branch anonrig:zlip/simplify-validators -> nodejs:main Labels zlib, needs-ci Commits 1 - zlib: simplify validators Committers 1 - Yagiz Nizipli <yagiz@nizipli.com> PR-URL: https://github.com/nodejs/node/pull/54442 Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54442 Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 18 Aug 2024 19:40:42 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54442#pullrequestreview-2244385886 ✘ This PR needs to wait 23 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-20T04:33:07Z: https://ci.nodejs.org/job/node-test-pull-request/61259/ - Querying data for job/node-test-pull-request/61259/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10541365863 |
anonrig
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54442 ✔ Done loading data for nodejs/node/pull/54442 ----------------------------------- PR info ------------------------------------ Title zlib: simplify validators (#54442) Author Yagiz Nizipli <yagiz@nizipli.com> (@anonrig) Branch anonrig:zlip/simplify-validators -> nodejs:main Labels zlib, needs-ci Commits 1 - zlib: simplify validators Committers 1 - Yagiz Nizipli <yagiz@nizipli.com> PR-URL: https://github.com/nodejs/node/pull/54442 Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54442 Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 18 Aug 2024 19:40:42 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54442#pullrequestreview-2244385886 ✘ This PR needs to wait 0 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-24T20:39:48Z: https://ci.nodejs.org/job/node-test-pull-request/61259/ - Querying data for job/node-test-pull-request/61259/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10549493354 |
anonrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ba07067 |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54442 Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54442 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies
zlibimplementation by moving validators tovalidators.jsfile.