[v22.x backport] doc: reserve ABI 130 for Electron 33 #54455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
I'm not sure whether the branch to target should be |
|
Found some docs about it and it looks like I need to potentially reformat my commit & indeed target |
clavin
force-pushed
the
clavin/doc-electron-33-abi-for-v22
branch
from
26ab808
to
a574bd5
Compare
clavin
changed the title
clavin
added a commit
to clavin/node
that referenced
this pull request
Aug 19, 2024
Backport-PR-URL: nodejs#54455 PR-URL: nodejs#54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
clavin
force-pushed
the
clavin/doc-electron-33-abi-for-v22
branch
from
a574bd5
to
2013511
Compare
|
👍 Alright, everything seems to be formatted properly now. I added the |
RafaelGSS
force-pushed
the
v22.x-staging
branch
from
3eab8ce
to
240d929
Compare
Backport-PR-URL: nodejs#54455 PR-URL: nodejs#54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
clavin
force-pushed
the
clavin/doc-electron-33-abi-for-v22
branch
from
2013511
to
a319641
Compare
|
|
RafaelGSS
approved these changes
Aug 24, 2024
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 24, 2024
Backport-PR-URL: #54455 PR-URL: #54383 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
|
Landed in 83b5efe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #54383 to
v22.x.