test: add tests for runner coverage with different stdout column widths #54494
Conversation
|
Review requested:
|
nodejs-github-bot
added
needs-ci
pmarchini
force-pushed
the
test/different-widths-runner-coverage
branch
from
d8bb713
to
1cf8c89
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54494 +/- ##
==========================================
- Coverage 87.34% 87.34% -0.01%
==========================================
Files 649 649
Lines 182518 182576 +58
Branches 35028 35041 +13
==========================================
+ Hits 159425 159471 +46
- Misses 16370 16380 +10
- Partials 6723 6725 +2 |
pmarchini
force-pushed
the
test/different-widths-runner-coverage
branch
from
1cf8c89
to
e6a18f8
Compare
There was a problem hiding this comment.
Some of the files are missing newlines at the bottom (GitHub shows a red circle with a line through it). LGTM other than that though. Thanks!
Some of the fixtures also don't follow the style guidelines because we don't lint the fixtures. Let's keep them though since it gives us a wider range of inputs to test coverage on.
By the way, I realize you were testing the formatting of the coverage report here. But, by any chance did you verify the data in the coverage report manually? I'm just asking because I'd like to try getting code coverage stable in the future, so any bugs we can get rid of are one step closer to that.
|
@cjihrig, No, I didn't, but while fixing the styling issues and newlines, I'm also going to take a look at the quality of the coverage itself 😁 |
pmarchini
force-pushed
the
test/different-widths-runner-coverage
branch
from
3e546b4
to
3f5526e
Compare
|
Hey @cjihrig, I linted the fixture files as much as possible without breaking the tests. In the meantime, I added more uncovered lines to create a repro for #51299. |
| # -------------------------------------------------------------------------------------------------- | ||
| # file | line % | branch % | funcs % | uncovered lines | ||
| # -------------------------------------------------------------------------------------------------- | ||
| # …ap/a.js | 55.77 | 100.00 | 0.00 | 5-7 9-11 13-15 17-19 29-30 40-42 45-47 50-52 |
There was a problem hiding this comment.
@cjihrig this is the same problem reported in the other ticket
github-actions
bot
removed
the
request-ci
|
CI (node-test-linux-ubuntu2204-64) is failing due to a flaky test reported in issue 52550. |
cjihrig
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in bec3425 |
PR-URL: #54494 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #54494 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
While working on #51299, I saw that we don't have snapshot tests related to the test runner's coverage output under different process.stdout.columns.
I think that we should add these tests before working on #51299 in order to have snapshots of the actual behavior before changing it