Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: support for collabs - talk amplification #54508

Closed
wants to merge 4 commits into from

Conversation

mhdawson
Copy link
Member

  • document that we support collaborators by amplifying their talks

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 22, 2024
@mhdawson
Copy link
Member Author

@anonrig - FYI in terms of recent request

@kyliewd - FYI to get your confirmation you can support this

@RedYetiDev RedYetiDev added the meta Issues and PRs related to the general management of the project. label Aug 22, 2024
doc/contributing/recognizing-contributors.md Outdated Show resolved Hide resolved
Comment on lines 45 to 51
When a collaborator is speaking at a public event they may request applification
by the Node.js accounts in social media. They can request that a post highlighting
that they are speaking at the event be amplified by the Node.js accounts by
making a request in the #nodejs-social channel in the OpenJS Foundation slack.
We trust that collaborators will only request applification when they believe
the event is revelant to a Node.js audience and the content of the post is
in line wit the norms of the project.
Copy link
Member

@RedYetiDev RedYetiDev Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
When a collaborator is speaking at a public event they may request applification
by the Node.js accounts in social media. They can request that a post highlighting
that they are speaking at the event be amplified by the Node.js accounts by
making a request in the #nodejs-social channel in the OpenJS Foundation slack.
We trust that collaborators will only request applification when they believe
the event is revelant to a Node.js audience and the content of the post is
in line wit the norms of the project.
When a collaborator is speaking at a public event, they may request amplification
from the Node.js social media accounts. They can request that a post highlighting
that they are speaking at the event be amplified by by
making a request in the #nodejs-social channel in the OpenJS Foundation slack.
We trust that collaborators will only request amplification when they believe
the event is revelant to the Node.js audience and the content of the post is
in line with the norms of the project.

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we should also discourage amplification of talks that stem from a commercial interest, even though this might be hard to define.

@tniessen
Copy link
Member

(On a side note, strictly speaking, the commit message does not adhere to our guidelines because there is no verb in there.)

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

doc/contributing/recognizing-contributors.md Outdated Show resolved Hide resolved
- document that we support collaborators by amplifying their talks

Signed-off-by: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Member Author

@tniessen believe I fixed the commit message. I think support is a verb but I guess not the way I had originally used it.

doc/contributing/recognizing-contributors.md Outdated Show resolved Hide resolved
doc/contributing/recognizing-contributors.md Outdated Show resolved Hide resolved
doc/contributing/recognizing-contributors.md Outdated Show resolved Hide resolved
mhdawson and others added 3 commits August 27, 2024 13:44
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
Co-authored-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
mhdawson added a commit that referenced this pull request Aug 27, 2024
- document that we support collaborators by amplifying their talks

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54508
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson
Copy link
Member Author

Landed in d813634

@mhdawson mhdawson closed this Aug 27, 2024
@tniessen
Copy link
Member

@mhdawson Yeah, admittedly, my comment was in the spirit of gcc's -Wall -Wextra -pedantic ... 😄 I would have been fine with leaving it as it was :)

RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
- document that we support collaborators by amplifying their talks

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54508
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
- document that we support collaborators by amplifying their talks

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #54508
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.