test: fix improper path to URL conversion #54509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54509 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 649 649
Lines 182524 182524
Branches 35026 35030 +4
=======================================
+ Hits 159420 159422 +2
- Misses 16373 16376 +3
+ Partials 6731 6726 -5 |
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Aug 23, 2024
jasnell
approved these changes
Aug 23, 2024
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4e68b54 |
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Aug 25, 2024
PR-URL: nodejs#54509 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 25, 2024
PR-URL: #54509 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54509 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54509 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
added
the
dont-land-on-v20.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are failing when I run them from a directory whose path contains URL-significant chars (e.g.
?,#,%). We should be usingpathToFileURL, so that's what this PR is doing.